Bug 50656 – WebKit2: Implement WebChromeClient::exceededDatabaseQuota

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Jessie Berlin]

This method must be implemented in order for HTML5 Databases to work in WebKit2, since each HTML5 Database starts off with a quota of 0.

<rdar://problem/8607023>

[Jessie Berlin]

Created attachment 75853 [details]
Patch

[Early Warning System Bot]

Attachment 75853 [details] did not build on qt:
Build output: http://queues.webkit.org/results/6796090

[WebKit Review Bot]

Attachment 75853 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/update-webkit']" exit_code: 2
Updating OpenSource
Incomplete data: Delta source ended unexpectedly at /usr/lib/git-core/git-svn line 5061

Died at WebKitTools/Scripts/update-webkit line 132.


If any of these errors are false positives, please file a bug against check-webkit-style.

[Jessie Berlin]

Created attachment 75910 [details]
Patch (with Qt build fix and windows version of MiniBrowser build fix)

I ran check-webkit-style locally (for both this and the previous patch) and it reported 0 errors.

[Adam Roben (:aroben)]

Comment on attachment 75910 [details]
Patch (with Qt build fix and windows version of MiniBrowser build fix)

View in context: https://bugs.webkit.org/attachment.cgi?id=75910&action=review

> WebKit2/UIProcess/API/qt/qwkpage.cpp:364
> +        0,  /* pageDidScroll */
> +        0 /* exceededDatabaseQuota */

Maybe you should match the existing spacing here?

> WebKitTools/WebKitTestRunner/TestController.cpp:139
> +        0, // pageDidScroll
> +        0 // exceededDatabaseQuota

And here.

> WebKitTools/WebKitTestRunner/TestController.cpp:242
> +        0, // pageDidScroll
> +        0 // exceededDatabaseQuota

And here.

[Jessie Berlin]

(In reply to comment #5)
> (From update of attachment 75910 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=75910&action=review
> 
> > WebKit2/UIProcess/API/qt/qwkpage.cpp:364
> > +        0,  /* pageDidScroll */
> > +        0 /* exceededDatabaseQuota */
> 
> Maybe you should match the existing spacing here?
> 
> > WebKitTools/WebKitTestRunner/TestController.cpp:139
> > +        0, // pageDidScroll
> > +        0 // exceededDatabaseQuota
> 
> And here.
> 
> > WebKitTools/WebKitTestRunner/TestController.cpp:242
> > +        0, // pageDidScroll
> > +        0 // exceededDatabaseQuota
> 
> And here.

I originally matched the existing spaces, and then check-webkit-style complained about the rule where there should only be one space before an end-of-line comment.

I will change them back to match the existing spaces.

Thanks for the review!

[Jessie Berlin]

Comment on attachment 75910 [details]
Patch (with Qt build fix and windows version of MiniBrowser build fix)

Committed in r73533
http://trac.webkit.org/changeset/73533