Bug 50647 - Migrate buildbot.py from xmlrpclib to json
Summary: Migrate buildbot.py from xmlrpclib to json
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: William Siegrist
URL: http://build.webkit.org
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-07 14:38 PST by William Siegrist
Modified: 2010-12-08 20:22 PST (History)
3 users (show)

See Also:


Attachments
change buildbot.py to use json instead of xmlrpc (5.02 KB, patch)
2010-12-07 15:07 PST, William Siegrist
eric: review+
Details | Formatted Diff | Diff
fixed tabs in ChangeLog and added python2.5 support with simplejson (5.16 KB, patch)
2010-12-07 15:51 PST, William Siegrist
eric: review+
Details | Formatted Diff | Diff
add blank line to ChangeLog, fix mockup of build_dictionary (5.16 KB, patch)
2010-12-07 18:10 PST, William Siegrist
eric: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
recreated patch from the root of the repo so CQ can apply it (5.27 KB, patch)
2010-12-08 07:35 PST, William Siegrist
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description William Siegrist 2010-12-07 14:38:34 PST
The latest version of buildbot removed the xmlrpc interface. We need to change the buildbot module in webkitpy to use the json interface instead.
Comment 1 William Siegrist 2010-12-07 15:07:41 PST
Created attachment 75847 [details]
change buildbot.py to use json instead of xmlrpc
Comment 2 Eric Seidel (no email) 2010-12-07 15:19:12 PST
Comment on attachment 75847 [details]
change buildbot.py to use json instead of xmlrpc

Your ChangeLog has tabs.  Looks good though.  Assuming you actually ran something like failure-reason which would use this.
Comment 3 William Siegrist 2010-12-07 15:51:51 PST
Created attachment 75848 [details]
fixed tabs in ChangeLog and added python2.5 support with simplejson
Comment 4 Eric Seidel (no email) 2010-12-07 16:10:55 PST
Comment on attachment 75848 [details]
fixed tabs in ChangeLog and added python2.5 support with simplejson

View in context: https://bugs.webkit.org/attachment.cgi?id=75848&action=review

Lgtm. I assume you ran test-webkitpy :)

> WebKitTools/ChangeLog:2
> +        Reviewed by NOBODY (OOPS!).

Normally there is a blank line before this one.
Comment 5 William Siegrist 2010-12-07 18:10:02 PST
Created attachment 75856 [details]
add blank line to ChangeLog, fix mockup of build_dictionary

No, I had not run test-webkitpy, but now I know better. It turns out I needed to update the mockup of build_dictionary to match the new layout of the json data. I also fixed the ChangeLog (again).
Comment 6 Eric Seidel (no email) 2010-12-07 20:10:08 PST
Comment on attachment 75856 [details]
add blank line to ChangeLog, fix mockup of build_dictionary

Thanks again!
Comment 7 WebKit Review Bot 2010-12-07 21:56:20 PST
Attachment 75847 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/update-webkit']" exit_code: 2
Updating OpenSource
Incomplete data: Delta source ended unexpectedly at /usr/lib/git-core/git-svn line 5061

Died at WebKitTools/Scripts/update-webkit line 132.


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 WebKit Commit Bot 2010-12-08 00:19:33 PST
Comment on attachment 75856 [details]
add blank line to ChangeLog, fix mockup of build_dictionary

Rejecting patch 75856 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'apply-attachment', '--force-clean', '--non-interactive', 75856]" exit_code: 2
Last 500 characters of output:
 up to this was:
--------------------------
|Index: Scripts/webkitpy/common/net/buildbot.py
|===================================================================
|--- Scripts/webkitpy/common/net/buildbot.py	(revision 73456)
|+++ Scripts/webkitpy/common/net/buildbot.py	(working copy)
--------------------------
No file to patch.  Skipping patch.
4 out of 4 hunks ignored

Failed to run "[u'/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Eric Seidel', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/6745109
Comment 9 William Siegrist 2010-12-08 07:35:16 PST
Created attachment 75903 [details]
recreated patch from the root of the repo so CQ can apply it
Comment 10 Eric Seidel (no email) 2010-12-08 10:43:40 PST
Comment on attachment 75903 [details]
recreated patch from the root of the repo so CQ can apply it

Thanks.
Comment 11 WebKit Commit Bot 2010-12-08 20:21:27 PST
The commit-queue encountered the following flaky tests while processing attachment 75903 [details]:

inspector/debugger-no-nested-pause.html

Please file bugs against the tests.  These tests were authored by loislo@chromium.org, podivilov@chromium.org, and yurys@chromium.org.  The commit-queue is continuing to process your patch.
Comment 12 WebKit Commit Bot 2010-12-08 20:22:36 PST
Comment on attachment 75903 [details]
recreated patch from the root of the repo so CQ can apply it

Clearing flags on attachment: 75903

Committed r73590: <http://trac.webkit.org/changeset/73590>
Comment 13 WebKit Commit Bot 2010-12-08 20:22:42 PST
All reviewed patches have been landed.  Closing bug.