Move DOMWindow::setLocation logic into DOMWindow class and out of JavaScript binding
Created attachment 75834 [details] Patch
Comment on attachment 75834 [details] Patch r=me
Attachment 75834 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/update-webkit']" exit_code: 2 Updating OpenSource Incomplete data: Delta source ended unexpectedly at /usr/lib/git-core/git-svn line 5061 Died at WebKitTools/Scripts/update-webkit line 132. If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r73521: <http://trac.webkit.org/changeset/73521>
It broke the whole world. :o Could you guys fix it?
I am in meetings all day and won’t have time to address this. Can someone roll it out for me? Sorry!
(In reply to comment #6) > I am in meetings all day and won’t have time to address this. Can someone roll it out for me? > > Sorry! Rolled out by http://trac.webkit.org/changeset/73532
I filed bug 50699 about the failures, but I guess we don't need it anymore.
Comment on attachment 75834 [details] Patch Clearing review+ flag, since this has been rolled out.
Committed r73647: <http://trac.webkit.org/changeset/73647>
This broke XSS tests: http://build.webkit.org/results/Leopard%20Intel%20Debug%20(Tests)/r73656%20(24484)/results.html
(In reply to comment #11) > This broke XSS tests: http://build.webkit.org/results/Leopard%20Intel%20Debug%20(Tests)/r73656%20(24484)/results.html I should have said "it seems like" this change broke XSS tests.
(In reply to comment #12) > (In reply to comment #11) > > This broke XSS tests: http://build.webkit.org/results/Leopard%20Intel%20Debug%20(Tests)/r73656%20(24484)/results.html > > I should have said "it seems like" this change broke XSS tests. Yes, it broke those and the fix was <http://trac.webkit.org/changeset/73660>. Do you think there’s anything still broken after r73660?