Bug 50632 – IndexedDB returns the wrong exceptions

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jeremy Orlow]

IndexedDB returns the wrong exceptions

[Jeremy Orlow]

Created attachment 75820 [details]
Patch

[WebKit Review Bot]

Attachment 75820 [details] did not pass style-queue:

Failed to run "[u'git', u'reset', u'--hard', u'refs/remotes/trunk']" exit_code: 128
error: Could not write new index file.
fatal: Could not reset index file to revision 'refs/remotes/trunk'.


If any of these errors are false positives, please file a bug against check-webkit-style.

[Hans Wennborg]

Comment on attachment 75820 [details]
Patch

Looks fine as far as I can tell. A few comments about the messages:


> WebCore/dom/ExceptionCode.cpp:231
> +    "A record/index/objectStore by the name you requested does not exist.",

I think we should avoid personal pronouns in these messages. Perhaps "... the requested name does not exist."?

> WebCore/dom/ExceptionCode.cpp:232
> +    "Your request cannot be completed due to a failed constraint.",

Ditto.

> WebCore/dom/ExceptionCode.cpp:233
> +    "The data you provided does not meet the requirements of the function.",

Ditto.

[WebKit Review Bot]

Attachment 75820 [details] did not pass style-queue:

Failed to run "[u'git', u'reset', u'--hard', u'refs/remotes/trunk']" exit_code: 128
error: Could not write new index file.
fatal: Could not reset index file to revision 'refs/remotes/trunk'.


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Review Bot]

Attachment 75820 [details] did not pass style-queue:

Failed to run "[u'git', u'reset', u'--hard', u'refs/remotes/trunk']" exit_code: 128
error: Could not write new index file.
fatal: Could not reset index file to revision 'refs/remotes/trunk'.


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Review Bot]

Attachment 75820 [details] did not pass style-queue:

Failed to run "[u'git', u'reset', u'--hard', u'refs/remotes/trunk']" exit_code: 128
error: Could not write new index file.
fatal: Could not reset index file to revision 'refs/remotes/trunk'.


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Review Bot]

Attachment 75820 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/update-webkit']" exit_code: 2
Updating OpenSource
Incomplete data: Delta source ended unexpectedly at /usr/lib/git-core/git-svn line 5061

Died at WebKitTools/Scripts/update-webkit line 132.


If any of these errors are false positives, please file a bug against check-webkit-style.

[Jeremy Orlow]

Another shot at the names.  Steve, can you please review?

[Jeremy Orlow]

Created attachment 75898 [details]
Patch

[Andrei Popescu]

LGTM

[Hans Wennborg]

Comment on attachment 75898 [details]
Patch

LGTM

> WebCore/dom/ExceptionCode.cpp:234
> +    "This function is not allowed to be called in such a context",

ultra nit: period.

> WebCore/dom/ExceptionCode.cpp:235
> +    "The data supplied cannot be serialized according to the structured cloning algorithm",

ditto

[Steve Block]

Comment on attachment 75898 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=75898&action=review

Are the new values set in the spec? Do you have a link?

> WebCore/bindings/js/JSDOMBinding.cpp:90
> +#include "IDBDatabaseExceptionException.h"

ExceptionException?

> WebCore/bindings/v8/V8Proxy.cpp:40
> +#include "IDBDatabaseException.h"

Should this be guarded? If not, why is it for JSC?

> WebCore/storage/IDBDatabaseException.idl:35
> +        readonly attribute DOMString        message;

Why the odd spacing?

[Jeremy Orlow]

(In reply to comment #12)
> (From update of attachment 75898 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=75898&action=review
> 
> Are the new values set in the spec? Do you have a link?

The new numerical values are not yet in the spec, but I intend to change the spec in the next day or two.  There's been a bug to do so for a while.
 
> > WebCore/bindings/js/JSDOMBinding.cpp:90
> > +#include "IDBDatabaseExceptionException.h"
> 
> ExceptionException?

Bah.  Good catch!
 
> > WebCore/bindings/v8/V8Proxy.cpp:40
> > +#include "IDBDatabaseException.h"
> 
> Should this be guarded? If not, why is it for JSC?

Just following conventions in the various files.

> > WebCore/storage/IDBDatabaseException.idl:35
> > +        readonly attribute DOMString        message;
> 
> Why the odd spacing?

Just copying from the other Exception files.

[Jeremy Orlow]

Created attachment 75918 [details]
Patch

[Steve Block]

Comment on attachment 75918 [details]
Patch

r=me

[Jeremy Orlow]

Committed r73605: <http://trac.webkit.org/changeset/73605>