Bug 50629 - [GTK] testwebdatasource - unreachable test is broken
Summary: [GTK] testwebdatasource - unreachable test is broken
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2010-12-07 07:18 PST by Gustavo Noronha (kov)
Modified: 2010-12-07 08:15 PST (History)
0 users

See Also:

Attachments
proposed patch (3.54 KB, patch)
2010-12-07 07:27 PST, Gustavo Noronha (kov) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gustavo Noronha (kov) 2010-12-07 07:18:52 PST 
The unreachable test is not testing what it needs to test, because it uses an incorrect condition in the load status notification callback, and unfortunately, after that is fixed the test does not pass. While I figure the problem out, I'll post a patch that fixes the test and disables it.
Comment 1 Gustavo Noronha (kov) 2010-12-07 07:27:29 PST 
Created attachment 75814 [details]
proposed patch
Comment 2 Gustavo Noronha (kov) 2010-12-07 08:14:55 PST 
Comment on attachment 75814 [details]
proposed patch

Xan reviewed the patch in person over my shoulder.
Comment 3 Gustavo Noronha (kov) 2010-12-07 08:15:11 PST 
Landed as 73442.