(Split from WebKit Bug 25770.) FontCacheChromiumWin.cpp inserts several helper functions between the methods of the WebCore::FontCache class. It is better to move these static functions at the beginning of this file to improve its readability. (*1) <http://svn.webkit.org/repository/webkit/trunk/WebCore/platform/graphics/chromium/FontCacheChromiumWin.cpp>
Created attachment 75775 [details] A refactoring change Greetings, This change just moved the static functions and fixed some style issues. (I'm not sure if it is better to use an anonymous namespace for these functions as Chromium code does, though.) Regards, Hironori Bono
Attachment 75775 [details] did not pass style-queue: Failed to run "[u'git', u'reset', u'--hard', u'HEAD']" exit_code: 128 error: Could not write new index file. fatal: Could not reset index file to revision 'HEAD'. If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 75775 [details] A refactoring change Clearing flags on attachment: 75775 Committed r73425: <http://trac.webkit.org/changeset/73425>
All reviewed patches have been landed. Closing bug.
Attachment 75775 [details] did not pass style-queue: Failed to run "[u'git', u'reset', u'--hard', u'refs/remotes/trunk']" exit_code: 128 error: Could not write new index file. fatal: Could not reset index file to revision 'refs/remotes/trunk'. If any of these errors are false positives, please file a bug against check-webkit-style.
Attachment 75775 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/update-webkit']" exit_code: 2 Updating OpenSource From git://git.webkit.org/WebKit 199e777..9473601 master -> origin/master Incomplete data: Delta source ended unexpectedly at /usr/lib/git-core/git-svn line 5061 Died at WebKitTools/Scripts/update-webkit line 132. If any of these errors are false positives, please file a bug against check-webkit-style.