An include of Document.h was added to V8DOMWrapper.h in http://trac.webkit.org/changeset/47921, but it appears this is no longer needed since the convertNodeToV8Object function that was using it is gone. (Same for the include of V8DOMMap.h.) I'd like to remove the stale include(s) to avoid a circular include chain introduced by the combination of Nate Chapin's change to Document.h (http://trac.webkit.org/changeset/73392) and my pending patch to NavigationAction.h (https://bugs.webkit.org/attachment.cgi?id=75044&action=review). Specifically, after Nate includes DocumentLoader from Document and I include HistoryItem from NavigationAction, it's possible for V8DOMWrapper to transitively include V8Proxy. That leads to this compile error: CXX(target) out/Debug/obj.target/webcore_bindings/gen/webkit/bindings/V8DerivedSources8.o In file included from third_party/WebKit/WebCore/bindings/v8/ScriptValue.h:41, from third_party/WebKit/WebCore/bindings/v8/SerializedScriptValue.h:34, from third_party/WebKit/WebCore/history/HistoryItem.h:31, from third_party/WebKit/WebCore/loader/NavigationAction.h:34, from third_party/WebKit/WebCore/loader/DocumentLoader.h:34, from third_party/WebKit/WebCore/dom/Document.h:36, from third_party/WebKit/WebCore/bindings/v8/V8DOMWrapper.h:34, from out/Debug/obj/gen/webkit/bindings/V8BeforeProcessEvent.h:25, from out/Debug/obj/gen/webcore/bindings/V8BeforeProcessEvent.cpp:22, from out/Debug/obj/gen/webkit/bindings/V8DerivedSources3.cpp:31: third_party/WebKit/WebCore/bindings/v8/V8Proxy.h: In static member function 'static v8::Handle<v8::Value> WebCore::V8Proxy::constructDOMObject(const v8::Arguments&, WebCore::WrapperTypeInfo*)': third_party/WebKit/WebCore/bindings/v8/V8Proxy.h:362: error: 'V8DOMWrapper' has not been declared third_party/WebKit/WebCore/bindings/v8/V8Proxy.h:364: error: 'V8DOMWrapper' has not been declared
Created attachment 75771 [details] Patch
Attachment 75771 [details] did not pass style-queue: Failed to run "[u'git', u'reset', u'--hard', u'HEAD']" exit_code: 128 error: Could not write new index file. fatal: Could not reset index file to revision 'HEAD'. If any of these errors are false positives, please file a bug against check-webkit-style.
Attachment 75771 [details] did not pass style-queue: Failed to run "[u'git', u'reset', u'--hard', u'refs/remotes/trunk']" exit_code: 128 error: Could not write new index file. fatal: Could not reset index file to revision 'refs/remotes/trunk'. If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 75771 [details] Patch I'm surprised Charlie isn't a committer yet.
The commit-queue encountered the following flaky tests while processing attachment 75771 [details]: animations/combo-transform-translate+scale.html bug 50958 (authors: cmarrin@apple.com, darin@apple.com, ojan@chromium.org, and pol@apple.com) animations/play-state-suspend.html bug 50959 (author: cmarrin@apple.com) The commit-queue is continuing to process your patch.
Comment on attachment 75771 [details] Patch Clearing flags on attachment: 75771 Committed r74014: <http://trac.webkit.org/changeset/74014>
All reviewed patches have been landed. Closing bug.