Bug 50600 - Prototype inheritance test fails due to constructor lookup failure
Summary: Prototype inheritance test fails due to constructor lookup failure
Status: UNCONFIRMED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-06 16:45 PST by Emil A Eklund
Modified: 2010-12-10 16:23 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.59 KB, patch)
2010-12-06 16:49 PST, Emil A Eklund 		no flags Details | Formatted Diff | Diff
Patch (2.59 KB, patch)
2010-12-06 16:54 PST, Emil A Eklund 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Emil A Eklund 2010-12-06 16:45:29 PST 
Prototype inheritance test fails due to constructor lookup failure
Comment 1 Emil A Eklund 2010-12-06 16:49:08 PST 
Created attachment 75752 [details]
Patch
Comment 2 WebKit Review Bot 2010-12-06 16:50:59 PST 
Attachment 75752 [details] did not pass style-queue:

Failed to run "[u'git', u'reset', u'--hard', u'HEAD']" exit_code: 128
error: Could not write new index file.
fatal: Could not reset index file to revision 'HEAD'.


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Emil A Eklund 2010-12-06 16:54:40 PST 
Created attachment 75753 [details]
Patch
Comment 4 WebKit Review Bot 2010-12-06 17:01:23 PST 
Attachment 75753 [details] did not pass style-queue:

Failed to run "[u'git', u'reset', u'--hard', u'HEAD']" exit_code: 128
error: Could not write new index file.
fatal: Could not reset index file to revision 'HEAD'.


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Eric Seidel (no email) 2010-12-09 15:28:19 PST 
I'm not sure I understand what this change is doing?
Comment 6 Emil A Eklund 2010-12-09 15:41:42 PST 
The test prototype-inheritance-2 is failing as the way it looks up available constructs doesn't work anymore. This change fixes the test by changing the way it does that lookup. At least that's the intention.
Comment 7 Eric Seidel (no email) 2010-12-09 15:46:56 PST 
Oh, so it's currently failing on the bots?  When did this regress?
Comment 8 Emil A Eklund 2010-12-09 15:49:46 PST 
Yeah, looks like it's been failing since July 30.
Comment 9 Eric Seidel (no email) 2010-12-09 15:51:21 PST 
I'm confused.  It's clearly not ben failing on Mac since that time.  Is this a chromium fix?  The results you're changing are common results.
Comment 10 Emil A Eklund 2010-12-09 15:54:57 PST 
No, it's for webkit but it might be limited to the gtk and windows ports. Let me check again (on all platforms) and get back to you.