UNCONFIRMED50600
Prototype inheritance test fails due to constructor lookup failure 
https://bugs.webkit.org/show_bug.cgi?id=50600
Summary Prototype inheritance test fails due to constructor lookup failure
Emil A Eklund
Reported 2010-12-06 16:45:29 PST
Prototype inheritance test fails due to constructor lookup failure
Attachments
Patch (2.59 KB, patch)
2010-12-06 16:49 PST, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
Patch (2.59 KB, patch)
2010-12-06 16:54 PST, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Emil A Eklund
Comment 1 2010-12-06 16:49:08 PST
Created attachment 75752 [details] Patch
WebKit Review Bot
Comment 2 2010-12-06 16:50:59 PST
Attachment 75752 [details] did not pass style-queue: Failed to run "[u'git', u'reset', u'--hard', u'HEAD']" exit_code: 128 error: Could not write new index file. fatal: Could not reset index file to revision 'HEAD'. If any of these errors are false positives, please file a bug against check-webkit-style.
Emil A Eklund
Comment 3 2010-12-06 16:54:40 PST
Created attachment 75753 [details] Patch
WebKit Review Bot
Comment 4 2010-12-06 17:01:23 PST
Attachment 75753 [details] did not pass style-queue: Failed to run "[u'git', u'reset', u'--hard', u'HEAD']" exit_code: 128 error: Could not write new index file. fatal: Could not reset index file to revision 'HEAD'. If any of these errors are false positives, please file a bug against check-webkit-style.
Eric Seidel (no email)
Comment 5 2010-12-09 15:28:19 PST
I'm not sure I understand what this change is doing?
Emil A Eklund
Comment 6 2010-12-09 15:41:42 PST
The test prototype-inheritance-2 is failing as the way it looks up available constructs doesn't work anymore. This change fixes the test by changing the way it does that lookup. At least that's the intention.
Eric Seidel (no email)
Comment 7 2010-12-09 15:46:56 PST
Oh, so it's currently failing on the bots? When did this regress?
Emil A Eklund
Comment 8 2010-12-09 15:49:46 PST
Yeah, looks like it's been failing since July 30.
Eric Seidel (no email)
Comment 9 2010-12-09 15:51:21 PST
I'm confused. It's clearly not ben failing on Mac since that time. Is this a chromium fix? The results you're changing are common results.
Emil A Eklund
Comment 10 2010-12-09 15:54:57 PST
No, it's for webkit but it might be limited to the gtk and windows ports. Let me check again (on all platforms) and get back to you.
Note You need to log in before you can comment on or make changes to this bug.