Bug 50588 – reserveAndCommit doesn't commit on MADVISE_FREE_REUSE systems

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Geoffrey Garen]

reserveAndCommit doesn't commit on MADVISE_FREE_REUSE systems

[Geoffrey Garen]

Created attachment 75734 [details]
Patch

[Geoffrey Garen]

Ignore that WebKitTools change -- it's a webkit-patch artifact.

[Maciej Stachowiak]

Comment on attachment 75734 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=75734&action=review

Looks good. See two comments inline. Make sure to dro the DumpRenderTree changes and it's r=me.

> JavaScriptCore/wtf/OSAllocatorPosix.cpp:43
> +    // MADV_FREE_REUSE reservations start out in the MADV_FREE_REUSE state, but
> +    // the reserve() API promises something in the MADV_FREE_REUSABLE state.

This comment confuses me. I guess there is a relevant difference between FREE_REUSE and FREE_REUSABLE which should be highlighted here, but it's not explained. May want to tweak it.

> WebKitTools/DumpRenderTree/mac/DumpRenderTree.mm:-353
> -    // maps expected result <= JavaScript expression
> -    NSDictionary *expressions = [NSDictionary dictionaryWithObjectsAndKeys:
> -        @"0", @"0", 
> -        @"0", @"'0'", 
> -        @"", @"",
> -        @"", @"''", 
> -        @"", @"new String()", 
> -        @"", @"new String('0')", 
> -        @"", @"throw 1", 
> -        @"", @"{ }", 
> -        @"", @"[ ]", 
> -        @"", @"//", 
> -        @"", @"a.b.c", 
> -        @"", @"(function() { throw 'error'; })()", 
> -        @"", @"null",
> -        @"", @"undefined",
> -        @"true", @"true",
> -        @"false", @"false",
> -        nil
> -    ];
> -
> -    NSAutoreleasePool *pool = [[NSAutoreleasePool alloc] init];

I don't think this, or the other DumpRenderTree changes, were intended.

[Geoffrey Garen]

Committed revision 73405.