WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
50583
Add a shim for GetCurrentEventButtonState
https://bugs.webkit.org/show_bug.cgi?id=50583
Summary
Add a shim for GetCurrentEventButtonState
Anders Carlsson
Reported
2010-12-06 12:44:23 PST
Add a shim for GetCurrentEventButtonState
Attachments
Patch
(6.19 KB, patch)
2010-12-06 12:46 PST
,
Anders Carlsson
aroben
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2010-12-06 12:46:08 PST
Created
attachment 75732
[details]
Patch
Adam Roben (:aroben)
Comment 2
2010-12-06 12:47:47 PST
Comment on
attachment 75732
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=75732&action=review
> WebKit2/WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:431 > EventRecord event = initializeEventRecord(eventKind); > + event.modifiers = modifiersForEvent(mouseEvent); > event.where.h = mouseEvent.globalPosition().x(); > event.where.v = mouseEvent.globalPosition().y(); > + > return NPP_HandleEvent(&event);
This seems unrelated to the rest of your patch. Your ChangeLog doesn't mention it either. Is it possible to add a test that shows this was missing before?
Anders Carlsson
Comment 3
2010-12-06 12:59:35 PST
Committed
r73391
: <
http://trac.webkit.org/changeset/73391
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug