Bug 50583 - Add a shim for GetCurrentEventButtonState
Summary: Add a shim for GetCurrentEventButtonState
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-06 12:44 PST by Anders Carlsson
Modified: 2010-12-06 12:59 PST (History)
0 users

See Also:

Attachments
Patch (6.19 KB, patch)
2010-12-06 12:46 PST, Anders Carlsson 		aroben: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2010-12-06 12:44:23 PST 
Add a shim for GetCurrentEventButtonState
Comment 1 Anders Carlsson 2010-12-06 12:46:08 PST 
Created attachment 75732 [details]
Patch
Comment 2 Adam Roben (:aroben) 2010-12-06 12:47:47 PST 
Comment on attachment 75732 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=75732&action=review

> WebKit2/WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:431
>              EventRecord event = initializeEventRecord(eventKind);
> +            event.modifiers = modifiersForEvent(mouseEvent);
>              event.where.h = mouseEvent.globalPosition().x();
>              event.where.v = mouseEvent.globalPosition().y();
> +
>              return NPP_HandleEvent(&event);

This seems unrelated to the rest of your patch. Your ChangeLog doesn't mention it either.

Is it possible to add a test that shows this was missing before?
Comment 3 Anders Carlsson 2010-12-06 12:59:35 PST 
Committed r73391: <http://trac.webkit.org/changeset/73391>