Bug 50577 - [GTK] WebKitSoupCache fails to load resources when cache contents are externally removed
Summary: [GTK] WebKitSoupCache fails to load resources when cache contents are externa...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P3 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2010-12-06 11:27 PST by Sergio Villar Senin
Modified: 2010-12-07 20:33 PST (History)
1 user (show)

See Also:


Attachments
Patch (5.85 KB, patch)
2010-12-06 11:34 PST, Sergio Villar Senin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Villar Senin 2010-12-06 11:27:42 PST
The cache silently fails to retrieve resources that are supposedly cached when it cannot create streams for them. That could happen if for example cache files are accidentally removed by any other actor but the cache.
Comment 1 Sergio Villar Senin 2010-12-06 11:34:35 PST
Created attachment 75716 [details]
Patch
Comment 2 Dan Winship 2010-12-07 03:30:26 PST
Comment on attachment 75716 [details]
Patch

xan asked me to review this. It looks right to me
Comment 3 WebKit Commit Bot 2010-12-07 19:52:52 PST
The commit-queue encountered the following flaky tests while processing attachment 75716 [details]:

fast/css/font-face-download-error.html
compositing/reflections/animation-inside-reflection.html

Please file bugs against the tests.  These tests were authored by simon.fraser@apple.com and yuzo@google.com.  The commit-queue is continuing to process your patch.
Comment 4 WebKit Commit Bot 2010-12-07 20:33:21 PST
Comment on attachment 75716 [details]
Patch

Clearing flags on attachment: 75716

Committed r73489: <http://trac.webkit.org/changeset/73489>
Comment 5 WebKit Commit Bot 2010-12-07 20:33:26 PST
All reviewed patches have been landed.  Closing bug.