Bug 50572 – [GTK] Support the Mozilla-style Fullscreen Javascript API

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Philippe Normand]

See also Bug 43099.
A new setting in WebView will be needed.

[Philippe Normand]

Created attachment 75731 [details]
proposed patch

[Philippe Normand]

Since r72321 the fullscreen css is not loaded though... So setting an element to fullscreen has no effect currently, the fullscreen tests pass however ;) I'll probably open a separate bug for that issue.

[Philippe Normand]

Later on we could adapt our FullscreenController or create a new one like in Bug 49481

[Martin Robinson]

Comment on attachment 75731 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=75731&action=review

Looks good. The only two issues I have are preventing the documentation from being in our public documentation and the naming of the configure variables.  

> WebKit/gtk/webkit/webkitwebsettings.cpp:913
> +    /**
> +    * WebKitWebSettings:enable-javascript-fullscreen:
> +    *
> +    * Enable or disable support for the Javascript Fullscreen API.
> +    *
> +    * Since: 1.3.8
> +    */

Let's leave this undocumented or unparsed now for now, so that it is private. I don't think we should expose this until other Mac does.

> configure.ac:475
> +              AC_HELP_STRING([--enable-javascript-fullscreen],

I think this should be --enable-fullscreen-api to match the flags on build-webkit and the #ifdef.

> configure.ac:478
> +AC_MSG_RESULT([$enable_javascript_fullscreen])

Ditto.

> configure.ac:960
> +AM_CONDITIONAL([ENABLE_JAVASCRIPT_FULLSCREEN],[test "$enable_javascript_fullscreen" = "yes"])

Ditto.

> configure.ac:1031
> + Javascript Fullscreen support                            : $enable_javascript_fullscreen

Ditto.

[Philippe Normand]

Created attachment 75909 [details]
proposed patch

[Martin Robinson]

Comment on attachment 75909 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=75909&action=review

Thanks! Please fix the small issue before landing.

> configure.ac:474
> +AC_ARG_ENABLE(javascript_fullscreen,

Better say fullscreen_api here to match the rest of the call.

[Philippe Normand]

Created attachment 76042 [details]
2010-12-06  Philippe Normand  <[e-mail]>

Reviewed by Martin Robinson.

        [GTK] Support the Mozilla-style Fullscreen Javascript API
        https://bugs.webkit.org/show_bug.cgi?id=50572

        * configure.ac: new configure flag to disable the new Javascript
        Fullscreen API build. It is enabled by default.

WebCore:

        Reviewed by Martin Robinson.

        [GTK] Support the Mozilla-style Fullscreen Javascript API
        https://bugs.webkit.org/show_bug.cgi?id=50572

        * GNUmakefile.am: enable the Javascript Fullscreen API feature if
        it's been requested at configure time.

WebKit/gtk:

        Reviewed by Martin Robinson.

        [GTK] Support the Mozilla-style Fullscreen Javascript API
        https://bugs.webkit.org/show_bug.cgi?id=50572

        Fullscreen API support. It is controlled at runtime using a new
        setting called enable-fullscreen, set to FALSE by default.

        * WebCoreSupport/ChromeClientGtk.cpp:
        (WebKit::ChromeClient::supportsFullScreenForElement):
        (WebKit::ChromeClient::enterFullScreenForElement):
        (WebKit::ChromeClient::exitFullScreenForElement):
        * WebCoreSupport/ChromeClientGtk.h:
        * webkit/webkitwebsettings.cpp:
        (webkit_web_settings_class_init):
        (webkit_web_settings_set_property):
        (webkit_web_settings_get_property):
        (webkit_web_settings_copy):
        * webkit/webkitwebview.cpp:
        (webkit_web_view_update_settings):

WebKitTools:

        Reviewed by Martin Robinson.

        [GTK] Support the Mozilla-style Fullscreen Javascript API
        https://bugs.webkit.org/show_bug.cgi?id=50572

        Enable the Javascript Fullscreen support in the GtkLauncher. Also
        make DRT update the Chrome when the WebView settings have been
        reset to consistent values.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (resetDefaultsToConsistentValues):
        * GtkLauncher/main.c:
        (create_window):
        * Scripts/build-webkit:

LayoutTests:

        Reviewed by Martin Robinson.

        [GTK] Support the Mozilla-style Fullscreen Javascript API
        https://bugs.webkit.org/show_bug.cgi?id=50572

        * platform/gtk/Skipped: Unskip now passing fullscreen tests.

[Martin Robinson]

Comment on attachment 76042 [details]
2010-12-06  Philippe Normand  <[e-mail]>

Yay!

[Philippe Normand]

Committed r73624: <http://trac.webkit.org/changeset/73624>