Bug 50561 – [gtk] Make PAN_SCROLLING a runtime setting and not a build time flag

• Status: RESOLVED
• Resolution: WONTFIX
• Component: WebKitGTK

[Diego Escalante Urrelo]

ssia.

Attaching a patch that:
 - makes it a runtime setting
 - updates the Qt port (which was relying on the flag)
 - adds a wrapper for the setting in the GTK+ port

Yes, I know it doesn't have a changelog, it would take me a few more days to update my webkit :)

[Diego Escalante Urrelo]

Created attachment 75674 [details]
First go, doesn't have a changelog, I know.

[Christian Dywan]

Created attachment 81068 [details]
Make pan scrolling a setting and not a build flag #2

Updated patch to build with current TOT. I also added an explanation what the feature does because it is impossible to find in a web search. Finding a more descriptive name would be nice, but I don't really know.

[Christian Dywan]

One thing I wondered after preparing the patch: is it also an option to unconditionally enable this or are there known drawbacks? It's overall not that complex so it doesn't really impact build time or size.

[Christian Dywan]

David, what do you think?

[Ben Stern]

In the UNIX Firefox world, middle clicking in a web page (if not on a link) pastes the X copy buffer.  This is inherited from old Netscape behavior.  I think that this is probably the expected behavior for UNIX users.

As far as I recall, middle-clicking in IE and Firefox under Windows triggers Pan Scrolling.  To Windows users, this is probably the expected behavior.

I do not know how to reconcile this difference in UI between platforms, but I thought I should add the additional information/

[Philippe Normand]

If you ever want a review of this patch you might want to mark it r?. :)

[Martin Robinson]

I don't think this is something we want for WebKitGTK+ ATM.