Bug 50545 - [chromium] Upstream skia/ImageBuffer.cpp routine mulDiv255Ceil()
Summary: [chromium] Upstream skia/ImageBuffer.cpp routine mulDiv255Ceil()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-05 15:26 PST by noel gordon
Modified: 2010-12-13 20:47 PST (History)
5 users (show)

See Also:


Attachments
patch (2.38 KB, patch)
2010-12-08 17:24 PST, noel gordon
no flags Details | Formatted Diff | Diff
patch try linux ews again (2.38 KB, patch)
2010-12-09 20:49 PST, noel gordon
eric: review+
Details | Formatted Diff | Diff
patch try linux ews take 2 (2.38 KB, patch)
2010-12-13 19:56 PST, noel gordon
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description noel gordon 2010-12-05 15:26:07 PST
As mentioned on bug 49365, we should upstream mulDiv255Ceil() to the skia repository.
Comment 1 noel gordon 2010-12-06 16:15:02 PST
patch sent http://codereview.appspot.com/3466042
Comment 2 noel gordon 2010-12-07 15:13:39 PST
landed http://code.google.com/p/skia/source/detail?r=632
Comment 3 noel gordon 2010-12-08 17:23:11 PST
skia rolled into chrome http://src.chromium.org/viewvc/chrome?view=rev&revision=68558
Comment 4 noel gordon 2010-12-08 17:24:01 PST
Created attachment 75991 [details]
patch
Comment 5 noel gordon 2010-12-08 19:24:09 PST
test_shell is happy before and after this patch
Comment 6 WebKit Review Bot 2010-12-09 01:14:49 PST
Attachment 75991 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/6959004
Comment 7 noel gordon 2010-12-09 20:48:20 PST
Checked out chromium & webkit ToT, built chromium linux debug/release with the patch fine.
Comment 8 noel gordon 2010-12-09 20:49:19 PST
Created attachment 76160 [details]
patch try linux ews again
Comment 9 WebKit Review Bot 2010-12-09 20:58:02 PST
Attachment 76160 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/6912020
Comment 10 noel gordon 2010-12-09 21:59:27 PST
waiting on EWS and chrome trys to update their chromium DEPS
Comment 11 Eric Seidel (no email) 2010-12-09 23:56:54 PST
Comment on attachment 76160 [details]
patch try linux ews again

LGTM.
Comment 12 Eric Seidel (no email) 2010-12-13 00:22:42 PST
Sadly we currently have no way to cause the EWS to retry other than to upload a new patch. :(
Comment 13 noel gordon 2010-12-13 18:49:40 PST
Understood, once bug 50984 lands, I will upload again.
Comment 14 noel gordon 2010-12-13 19:56:21 PST
Created attachment 76488 [details]
patch try linux ews take 2

resending.
Comment 15 WebKit Review Bot 2010-12-13 20:32:44 PST
The commit-queue encountered the following flaky tests while processing attachment 76488 [details]:

inspector/elements-panel-styles.html bug 50987 (author: pfeldman@chromium.org)
animations/suspend-resume-animation.html bug 51004 (author: cmarrin@apple.com)
The commit-queue is continuing to process your patch.
Comment 16 WebKit Review Bot 2010-12-13 20:47:51 PST
Comment on attachment 76488 [details]
patch try linux ews take 2

Clearing flags on attachment: 76488

Committed r73997: <http://trac.webkit.org/changeset/73997>
Comment 17 WebKit Review Bot 2010-12-13 20:47:57 PST
All reviewed patches have been landed.  Closing bug.