Bug 50541 - [GTK] using shadows leaks memory
Summary: [GTK] using shadows leaks memory
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Major
Assignee: Nobody
URL: http://droppy.lophus.org/cvDCE-index....
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-05 11:30 PST by Kristoffer Kleine
Modified: 2010-12-06 08:02 PST (History)
2 users (show)

See Also:

Attachments
archive with some example apps to reproduce the bug (1.36 KB, application/x-bzip)
2010-12-05 11:30 PST, Kristoffer Kleine 		no flags Details
Proposed patch (2.87 KB, patch)
2010-12-06 07:13 PST, Alejandro G. Castro 		mrobinson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kristoffer Kleine 2010-12-05 11:30:27 PST 
Created attachment 75634 [details]
archive with some example apps to reproduce the bug

WebkitGtk seems to leak memory when using css shadows. 
On my machine with webkit-nightly (72146) it leaks about 0.3 Mb/s when doing some moderate clicking on the element in the example.

To reproduce do:
1) Load the url (http://droppy.lophus.org/cvDCE-index.html) in Epiphany and click or hover the element and watch the memory increase.
2) see the attached examples (./build.sh to compile and ./example or python example.py to run). The symptoms are the same here, when clicking or hovering.
Comment 1 Sebastian Billaudelle 2010-12-05 11:40:17 PST 
Same for me here! With Midori, Epiphany and the examples attached by Krisoffer.
Comment 2 Alejandro G. Castro 2010-12-06 07:13:58 PST 
Created attachment 75690 [details]
Proposed patch

Thanks for reporting, I've fixed the two leaks in the shadows code found with valgrind.
Comment 3 Martin Robinson 2010-12-06 07:40:23 PST 
Comment on attachment 75690 [details]
Proposed patch

Awesome. Thanks!
Comment 4 Alejandro G. Castro 2010-12-06 08:02:35 PST 
landed http://trac.webkit.org/changeset/73367