Bug 50523 - [WINCE] Adds a build slave.
Summary: [WINCE] Adds a build slave.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on: 51642
Blocks:
  Show dependency treegraph
 
Reported: 2010-12-04 12:43 PST by Patrick R. Gansterer
Modified: 2011-01-03 13:51 PST (History)
2 users (show)

See Also:


Attachments
Patch (3.44 KB, patch)
2010-12-04 12:58 PST, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2010-12-04 12:43:10 PST
see patch
Comment 1 Patrick R. Gansterer 2010-12-04 12:58:02 PST
Created attachment 75614 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-12-12 02:31:27 PST
_wms should "review" this.
Comment 3 Csaba Osztrogonác 2010-12-13 06:13:22 PST
Comment on attachment 75614 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=75614&action=review

> WebKitTools/BuildSlaveSupport/build.webkit.org-config/master.cfg:83
>  def appendCustomBuildFlags(step, platform):
> -    if platform in ('gtk', 'wx', 'qt', 'chromium', 'wincairo', 'efl'):
> +    if platform in ('chromium', 'efl', 'gtk', 'qt', 'wincairo', 'wince', 'wx'):
>          step.setCommand(step.command + ['--' + platform])

It would pass --wince option to the build-webkit script.
But I can't find if build-webkit handles wince option.
Comment 4 Patrick R. Gansterer 2010-12-13 06:17:30 PST
(In reply to comment #3)
> (From update of attachment 75614 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=75614&action=review
> 
> > WebKitTools/BuildSlaveSupport/build.webkit.org-config/master.cfg:83
> >  def appendCustomBuildFlags(step, platform):
> > -    if platform in ('gtk', 'wx', 'qt', 'chromium', 'wincairo', 'efl'):
> > +    if platform in ('chromium', 'efl', 'gtk', 'qt', 'wincairo', 'wince', 'wx'):
> >          step.setCommand(step.command + ['--' + platform])
> 
> It would pass --wince option to the build-webkit script.
> But I can't find if build-webkit handles wince option.

I didn't added the --wince option to build-webkit (I need to take care of the EFL port, which uses CMake too).
Comment 5 David Kilzer (:ddkilzer) 2011-01-03 12:01:18 PST
Comment on attachment 75614 [details]
Patch

r=me

I'll let Patrick set the cq+ flag since this depends on Bug 51642 landing first.
Comment 6 Patrick R. Gansterer 2011-01-03 13:11:25 PST
Comment on attachment 75614 [details]
Patch

Clearing flags on attachment: 75614

Manually committed r74930: <http://trac.webkit.org/changeset/74930>
Comment 7 Patrick R. Gansterer 2011-01-03 13:11:52 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 William Siegrist 2011-01-03 13:51:32 PST
Buildbot updated.