Bug 50512 - API Documentation referencing depreciated GTK_WIDGET_TOPLEVEL
Summary: API Documentation referencing depreciated GTK_WIDGET_TOPLEVEL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Minor
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-03 21:10 PST by Derek
Modified: 2010-12-06 03:23 PST (History)
2 users (show)

See Also:

Attachments
Proposed Patch (922 bytes, patch)
2010-12-03 21:14 PST, Derek 		no flags Details | Formatted Diff | Diff
Proposed Patch (928 bytes, patch)
2010-12-03 21:19 PST, Derek 		no flags Details | Formatted Diff | Diff
Proposed Patch (1.46 KB, patch)
2010-12-04 21:32 PST, Derek 		mrobinson: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Derek 2010-12-03 21:10:00 PST 
On the API page describing WebKitWebView (http://webkitgtk.org/reference/webkitgtk-webkitwebview.html) in the API reference, an example uses the depreciated GTK_WIDGET_TOPLEVEL.

https://bugs.webkit.org/show_bug.cgi?id=33486 fixed the bug, but not the in-code documentation.
Comment 1 Derek 2010-12-03 21:14:56 PST 
Created attachment 75594 [details]
Proposed Patch
Comment 2 Derek 2010-12-03 21:19:58 PST 
Created attachment 75595 [details]
Proposed Patch

Updated patch with bug link.
Comment 3 Martin Robinson 2010-12-04 18:55:59 PST 
Seems reasonable to me, but do you mind attaching a ChangeLog to your patch? See here: http://webkit.org/coding/contributing.html
Comment 4 Derek 2010-12-04 21:32:33 PST 
Created attachment 75625 [details]
Proposed Patch

Proposed patch with ChangeLog.
Comment 5 Martin Robinson 2010-12-06 02:51:52 PST 
Comment on attachment 75625 [details]
Proposed Patch

Thanks!
Comment 6 Martin Robinson 2010-12-06 03:23:23 PST 
Committed r73354: <http://trac.webkit.org/changeset/73354>