RESOLVED FIXED Bug 50512
API Documentation referencing depreciated GTK_WIDGET_TOPLEVEL 
https://bugs.webkit.org/show_bug.cgi?id=50512
Summary API Documentation referencing depreciated GTK_WIDGET_TOPLEVEL
Derek
Reported 2010-12-03 21:10:00 PST
On the API page describing WebKitWebView (http://webkitgtk.org/reference/webkitgtk-webkitwebview.html) in the API reference, an example uses the depreciated GTK_WIDGET_TOPLEVEL. https://bugs.webkit.org/show_bug.cgi?id=33486 fixed the bug, but not the in-code documentation.
Attachments
Proposed Patch (922 bytes, patch)
2010-12-03 21:14 PST, Derek 		no flags
DetailsFormatted DiffDiff
Proposed Patch (928 bytes, patch)
2010-12-03 21:19 PST, Derek 		no flags
DetailsFormatted DiffDiff
Proposed Patch (1.46 KB, patch)
2010-12-04 21:32 PST, Derek 		mrobinson: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Derek
Comment 1 2010-12-03 21:14:56 PST
Created attachment 75594 [details] Proposed Patch
Derek
Comment 2 2010-12-03 21:19:58 PST
Created attachment 75595 [details] Proposed Patch Updated patch with bug link.
Martin Robinson
Comment 3 2010-12-04 18:55:59 PST
Seems reasonable to me, but do you mind attaching a ChangeLog to your patch? See here: http://webkit.org/coding/contributing.html
Derek
Comment 4 2010-12-04 21:32:33 PST
Created attachment 75625 [details] Proposed Patch Proposed patch with ChangeLog.
Martin Robinson
Comment 5 2010-12-06 02:51:52 PST
Comment on attachment 75625 [details] Proposed Patch Thanks!
Martin Robinson
Comment 6 2010-12-06 03:23:23 PST
Committed r73354: <http://trac.webkit.org/changeset/73354>
Note You need to log in before you can comment on or make changes to this bug.