WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
50509
set* methods on MacroAssembler are awfully named.
https://bugs.webkit.org/show_bug.cgi?id=50509
Summary
set* methods on MacroAssembler are awfully named.
Gavin Barraclough
Reported
2010-12-03 18:44:47 PST
Methods set32 and setTest32 compare 32-bit operands, and set a 32-bit results based on the comparison. set8 compares 32-bit operands, and sets an 8-bit result based on the comparison. setTest8 compares 8-bit operands, and sets a 32-bit result based on the comparison. Rename to clarify. set32 -> set32Compare32 setTest32 -> set32Test32 set8 -> set8Compare32 setTest8 -> set32Test8
Attachments
Add attachment
proposed patch, testcase, etc.
Gavin Barraclough
Comment 1
2010-12-03 18:47:08 PST
Committed revision 73323.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug