Bug 50508 - The JavaScript created (untrusted) event inside a user-initiated(trusted) event should not cache the UserGesture status
: The JavaScript created (untrusted) event inside a user-initiated(trusted) eve...
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: Tools / Tests
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To: Nobody
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-12-03 17:56 PST by Johnny(Jianning) Ding
Modified: 2010-12-04 04:16 PST (History)
3 users (show)

See Also:


Attachments
patch (4.39 KB, patch)
2010-12-03 19:04 PST, Johnny(Jianning) Ding
ap: review+
Details | Formatted Diff | Diff
patch V2 (4.42 KB, patch)
2010-12-03 22:46 PST, Johnny(Jianning) Ding
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Johnny(Jianning) Ding 2010-12-03 17:56:48 PST
The detailed story was in https://bugs.webkit.org/show_bug.cgi?id=50386.

Echo Alexey's suggestion, add a layout test to avoid future regressions. 
Creating this bug is about to track the patch.
Comment 1 Johnny(Jianning) Ding 2010-12-03 19:04:45 PST
Created attachment 75590 [details]
patch
Comment 2 Alexey Proskuryakov 2010-12-03 22:05:24 PST
Comment on attachment 75590 [details]
patch

It's confusing that the result is written out at the end of each stage - it's only the second write that matters.
Comment 3 Johnny(Jianning) Ding 2010-12-03 22:46:20 PST
Created attachment 75600 [details]
patch V2

(In reply to comment #2)
> (From update of attachment 75590 [details])
> It's confusing that the result is written out at the end of each stage - it's only the second write that matters.

You are right, I think the test should stop once it encounters a failure. 
Here is the new patch, please take a look:)
Comment 4 WebKit Commit Bot 2010-12-04 02:29:34 PST
The commit-queue encountered the following flaky tests while processing attachment 75600 [details]:

fast/preloader/script.html
animations/combo-transform-translate+scale.html

Please file bugs against the tests.  These tests were authored by abarth@webkit.org, cmarrin@apple.com, darin@apple.com, ojan@chromium.org, and pol@apple.com.  The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2010-12-04 02:59:00 PST
The commit-queue encountered the following flaky tests while processing attachment 75600 [details]:

fast/preloader/script.html
animations/combo-transform-translate+scale.html

Please file bugs against the tests.  These tests were authored by abarth@webkit.org, cmarrin@apple.com, darin@apple.com, ojan@chromium.org, and pol@apple.com.  The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2010-12-04 04:15:54 PST
Comment on attachment 75600 [details]
patch V2

Clearing flags on attachment: 75600

Committed r73327: <http://trac.webkit.org/changeset/73327>
Comment 7 WebKit Commit Bot 2010-12-04 04:16:01 PST
All reviewed patches have been landed.  Closing bug.