Bug 50501 - Postpone gl delete* calls until shaders/programs are no longer attached
Summary: Postpone gl delete* calls until shaders/programs are no longer attached
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Zhenyao Mo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-03 15:55 PST by Zhenyao Mo
Modified: 2010-12-06 15:17 PST (History)
4 users (show)

See Also:


Attachments
patch (9.21 KB, patch)
2010-12-03 16:05 PST, Zhenyao Mo
kbr: review+
zmo: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zhenyao Mo 2010-12-03 15:55:48 PST
By doing this, chromium command buffer won't have to change its behavior and will pass the conformance test
Comment 1 Zhenyao Mo 2010-12-03 16:05:55 PST
Created attachment 75571 [details]
patch

Manually ran chrome with command buffer, object-deletion-behavior.html is passing with this patch.
Comment 2 Kenneth Russell 2010-12-06 14:21:06 PST
Comment on attachment 75571 [details]
patch

The changes look good, but do the existing layout tests sufficiently cover these code paths?
Comment 3 Zhenyao Mo 2010-12-06 14:38:31 PST
We have object-deletion-behavior.html checked into LayoutTests, which covers this deletion code path.
Comment 4 Kenneth Russell 2010-12-06 14:39:43 PST
Comment on attachment 75571 [details]
patch

OK.
Comment 5 Zhenyao Mo 2010-12-06 15:17:24 PST
Committed r73406: <http://trac.webkit.org/changeset/73406>