Bug 50493 – Web Inspector: [Extension API] add support for adding/overriding HTTP request headers

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Andrey Kosyakov]

Being able to modify HTTP request headers for requests generated by the inspected page would allow an extension to communicate with server via custom server (think FirePHP), control caching policies or set custom user agents.

[Andrey Kosyakov]

Created attachment 75556 [details]
patch

[Pavel Feldman]

Comment on attachment 75556 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=75556&action=review

> WebCore/inspector/InspectorController.h:178
> +    void applyOverrideHeaders(ResourceRequest&);

Can you do this in willSendRequest instead?

> WebCore/inspector/front-end/ExtensionServer.js:161
> +	var allHeaders = {};

Wrong indent

[Andrey Kosyakov]

Created attachment 76538 [details]
patch

- now applying header overrides in InspectorController::willSendReqeust()
- fixed test output stability
- rebased
- fixed style

[Pavel Feldman]

Comment on attachment 76538 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=76538&action=review

> WebCore/inspector/InspectorController.cpp:1833
> +        m_overrideHeaders->add(it->first, value);

These are not necessarily "override" header since they are going to be overriden by the network stack. "Extra" headers?

[Andrey Kosyakov]

Created attachment 76668 [details]
patch to land

- rebased
- overrideHeaders -> extraHeaders

[Eric Seidel (no email)]

Did you mean to mark you r"patch to land" with cq+ or r? or something?  Or did it already get landed?

[Andrey Kosyakov]

(In reply to comment #6)
> Did you mean to mark you r"patch to land" with cq+ or r? or something?  Or did it already get landed?

Neither -- this was meant to be "JFYI only". I'm about to land manually later at a convenient moment (the tests may be platform-sensitive and I'd like to keep an eye on them).

[Andrey Kosyakov]

Manually committed r74234: http://trac.webkit.org/changeset/74234