Bug 50492 - [chromium] fix 2 bugs with inspector tests in DRT
Summary: [chromium] fix 2 bugs with inspector tests in DRT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-03 15:12 PST by Tony Chang
Modified: 2010-12-06 09:35 PST (History)
2 users (show)

See Also:


Attachments
Patch (4.55 KB, patch)
2010-12-03 15:25 PST, Tony Chang
no flags Details | Formatted Diff | Diff
Patch (4.66 KB, patch)
2010-12-03 16:44 PST, Tony Chang
tkent: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2010-12-03 15:12:57 PST
[chromium] fix 2 bugs with inspector tests in DRT
Comment 1 Tony Chang 2010-12-03 15:25:41 PST
Created attachment 75557 [details]
Patch
Comment 2 Kent Tamura 2010-12-03 15:52:48 PST
Comment on attachment 75557 [details]
Patch

LGTM
Comment 3 Tony Chang 2010-12-03 16:44:32 PST
Created attachment 75580 [details]
Patch
Comment 4 Tony Chang 2010-12-03 16:45:32 PST
Sorry, I was removing elements from the tasklist while iterating over it.  Switched to using "while (!m_tasks.isEmpty())".
Comment 5 Tony Chang 2010-12-06 09:35:19 PST
Committed r73373: <http://trac.webkit.org/changeset/73373>