RESOLVED FIXED 50487
[Qt] Flash plugins should work in windowless mode on QGraphicsWebView 
https://bugs.webkit.org/show_bug.cgi?id=50487
Summary [Qt] Flash plugins should work in windowless mode on QGraphicsWebView
Viatcheslav Ostapenko
Reported 2010-12-03 14:41:28 PST
Flash plugins should work in windowless mode on QGraphicsWebView. Default mode for Nokia flash plugin will be windowless. Generally, #ifdef introduced by commit r69396 should be removed.
Attachments
Remove #ifdef OS(SYMBIAN) (1.58 KB, patch)
2010-12-03 15:05 PST, Viatcheslav Ostapenko 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Viatcheslav Ostapenko
Comment 1 2010-12-03 15:05:43 PST
Created attachment 75548 [details] Remove #ifdef OS(SYMBIAN)
Laszlo Gombos
Comment 2 2010-12-07 10:16:15 PST
Comment on attachment 75548 [details] Remove #ifdef OS(SYMBIAN) Looks good to me, r+. However I'd like to hear from Hui that he is OK committing the change; cq- for now.
Hui Huang
Comment 3 2010-12-07 10:28:36 PST
The reason to disable the code to force Flash plugin to run in Windowless mode on Symbian was based on the comments from Symbian Flash Player developers that Symbian Flash Player works better in Windowed mode. Simon already commented about the problems with windowed plugin in Qt Graphics View. If running in Windowless mode is no longer a problem for Symbian Flash Player, I don't have any problem with this patch.
Eric Seidel (no email)
Comment 4 2010-12-14 01:25:08 PST
Sounds like this should be cq+'d now?
Hui Huang
Comment 5 2010-12-14 10:07:47 PST
I think so.
Laszlo Gombos
Comment 6 2010-12-14 13:15:26 PST
Comment on attachment 75548 [details] Remove #ifdef OS(SYMBIAN) cq+. Laszlo
WebKit Commit Bot
Comment 7 2010-12-14 13:35:49 PST
Comment on attachment 75548 [details] Remove #ifdef OS(SYMBIAN) Clearing flags on attachment: 75548 Committed r74057: <http://trac.webkit.org/changeset/74057>
WebKit Commit Bot
Comment 8 2010-12-14 13:35:55 PST
All reviewed patches have been landed. Closing bug.
Ademar Reis
Comment 9 2011-01-03 05:30:42 PST
Revision r74057 cherry-picked into qtwebkit-2.2 with commit cc20929 <http://gitorious.org/webkit/qtwebkit/commit/cc20929>
Note You need to log in before you can comment on or make changes to this bug.