Bug 50482 - Crash trying to empty caches with no WebProcess.
Summary: Crash trying to empty caches with no WebProcess.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2010-12-03 13:48 PST by Brady Eidson
Modified: 2010-12-03 14:07 PST (History)
0 users

See Also:


Attachments
Proprosed fix v1 (4.05 KB, patch)
2010-12-03 13:51 PST, Brady Eidson
sam: review-
Details | Formatted Diff | Diff
Fix v2 (5.36 KB, patch)
2010-12-03 14:00 PST, Brady Eidson
sam: review+
beidson: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2010-12-03 13:48:56 PST
We crash trying to empty caches in a WKContext with no WebProcess.

In radar as <rdar://problem/8725679>
Comment 1 Brady Eidson 2010-12-03 13:51:44 PST
Created attachment 75538 [details]
Proprosed fix v1
Comment 2 Sam Weinig 2010-12-03 13:53:39 PST
Comment on attachment 75538 [details]
Proprosed fix v1

View in context: https://bugs.webkit.org/attachment.cgi?id=75538&action=review

> WebKit2/UIProcess/WebContext.cpp:182
> +    if (m_clearResourceCachesForNewWebProcess) {
> +        m_process->send(Messages::WebProcess::ClearResourceCaches(), 0);
> +        m_clearResourceCachesForNewWebProcess = false;
> +    }
> +    
> +    if (m_clearApplicationCacheForNewWebProcess) {
> +        m_process->send(Messages::WebProcess::ClearApplicationCache(), 0);
> +        m_clearApplicationCacheForNewWebProcess = false;
> +    }

This should use the process initialization message idiom used above in this function, instead of sending its own messages.
Comment 3 Brady Eidson 2010-12-03 14:00:59 PST
Created attachment 75539 [details]
Fix v2
Comment 4 Brady Eidson 2010-12-03 14:07:05 PST
http://trac.webkit.org/changeset/73299