Bug 50464 - Clean up some text-related code on GraphicsContext
Summary: Clean up some text-related code on GraphicsContext
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on: 50474
Blocks:
  Show dependency tree / graph
 
Reported: 2010-12-03 10:59 PST by Simon Fraser (smfr)
Modified: 2010-12-03 13:12 PST (History)
6 users (show)

See Also:

Attachments
Patch (34.94 KB, patch)
2010-12-03 11:36 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (34.93 KB, patch)
2010-12-03 11:37 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (3.31 KB, patch)
2010-12-03 11:52 PST, Simon Fraser (smfr) 		krit: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2010-12-03 10:59:52 PST 
Cleanup coming.
Comment 1 Simon Fraser (smfr) 2010-12-03 11:36:15 PST 
Created attachment 75517 [details]
Patch
Comment 2 Simon Fraser (smfr) 2010-12-03 11:37:59 PST 
Created attachment 75518 [details]
Patch
Comment 3 Nikolas Zimmermann 2010-12-03 11:52:12 PST 
Comment on attachment 75518 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=75518&action=review

Looks great, r=me.

> WebCore/platform/graphics/chromium/FontLinux.cpp:656
> +    bool stroke = (textMode & TextModeStroke)

Superfluous braces.
Comment 4 Simon Fraser (smfr) 2010-12-03 11:52:59 PST 
Created attachment 75520 [details]
Patch
Comment 5 Simon Fraser (smfr) 2010-12-03 12:09:03 PST 
Comment on attachment 75518 [details]
Patch

http://trac.webkit.org/changeset/73284
Comment 6 Dirk Schulze 2010-12-03 12:23:48 PST 
Comment on attachment 75520 [details]
Patch

LGTM. r=me
Comment 7 WebKit Review Bot 2010-12-03 12:25:05 PST 
Attachment 75518 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/6728031
Comment 8 Simon Fraser (smfr) 2010-12-03 13:12:38 PST 
http://trac.webkit.org/changeset/73292