RESOLVED FIXED Bug 50445
[CMake] Remove WebKitGenerators 
https://bugs.webkit.org/show_bug.cgi?id=50445
Summary [CMake] Remove WebKitGenerators
Patrick R. Gansterer
Reported 2010-12-03 01:52:01 PST
see patch
Attachments
Patch (14.22 KB, patch)
2010-12-03 02:02 PST, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Patch (14.22 KB, patch)
2010-12-03 04:31 PST, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Patch (part 1) (2.90 KB, patch)
2010-12-03 06:04 PST, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Patch (part 2) (1.37 KB, patch)
2010-12-03 11:54 PST, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Patch (part 3) (11.73 KB, patch)
2010-12-03 14:57 PST, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Patch (part 3) (13.09 KB, patch)
2010-12-06 11:06 PST, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Patch (part 3) (13.30 KB, patch)
2010-12-06 11:21 PST, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Patch (part 4) (3.59 KB, patch)
2010-12-27 05:10 PST, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Patch (part 4) (3.59 KB, patch)
2010-12-28 14:19 PST, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2010-12-03 02:02:19 PST
Created attachment 75476 [details] Patch cq- because I want to get the EFL EWS result first.
Andreas Kling
Comment 2 2010-12-03 03:01:02 PST
Comment on attachment 75476 [details] Patch Looks sane, r=me
Andreas Kling
Comment 3 2010-12-03 03:02:56 PST
(In reply to comment #1) > cq- because I want to get the EFL EWS result first. EFL EWS has indeed failed on this, please check that before landing :)
Patrick R. Gansterer
Comment 4 2010-12-03 04:31:19 PST
Created attachment 75487 [details] Patch
Patrick R. Gansterer
Comment 5 2010-12-03 04:32:40 PST
Comment on attachment 75487 [details] Patch already reviewed. set r? only for efl ews
Patrick R. Gansterer
Comment 6 2010-12-03 06:04:34 PST
Created attachment 75495 [details] Patch (part 1) I've split the patch, to see if this part works in the efl ews
Patrick R. Gansterer
Comment 7 2010-12-03 10:19:26 PST
Comment on attachment 75495 [details] Patch (part 1) Clearing flags on attachment: 75495 Committed r73273: <http://trac.webkit.org/changeset/73273>
Patrick R. Gansterer
Comment 8 2010-12-03 11:54:27 PST
Created attachment 75521 [details] Patch (part 2) already reviewed. set r? only for efl ews
Patrick R. Gansterer
Comment 9 2010-12-03 14:46:16 PST
Comment on attachment 75521 [details] Patch (part 2) Clearing flags on attachment: 75521 Committed r73289: <http://trac.webkit.org/changeset/73289>
Patrick R. Gansterer
Comment 10 2010-12-03 14:57:23 PST
Created attachment 75547 [details] Patch (part 3) already reviewed. set r? only for efl ews
Patrick R. Gansterer
Comment 11 2010-12-06 11:06:06 PST
Created attachment 75712 [details] Patch (part 3) Try "part 3" again
Patrick R. Gansterer
Comment 12 2010-12-06 11:21:55 PST
Created attachment 75713 [details] Patch (part 3)
Patrick R. Gansterer
Comment 13 2010-12-07 03:27:59 PST
Comment on attachment 75713 [details] Patch (part 3) Clearing flags on attachment: 75713 Committed r73434: <http://trac.webkit.org/changeset/73434>
Eric Seidel (no email)
Comment 14 2010-12-14 01:26:17 PST
Comment on attachment 75476 [details] Patch Cleared Andreas Kling's review+ from obsolete attachment 75476 [details] so that this bug does not appear in http://webkit.org/pending-commit.
Kenneth Rohde Christiansen
Comment 15 2010-12-24 02:27:52 PST
Is that first patch up for review still?
Patrick R. Gansterer
Comment 16 2010-12-24 03:06:01 PST
Comment on attachment 75487 [details] Patch (In reply to comment #15) > Is that first patch up for review still? No, thanks.
Patrick R. Gansterer
Comment 17 2010-12-27 05:10:50 PST
Created attachment 77492 [details] Patch (part 4) already reviewed. set r? only for efl ews
Patrick R. Gansterer
Comment 18 2010-12-28 14:19:05 PST
Created attachment 77577 [details] Patch (part 4)
WebKit Commit Bot
Comment 19 2010-12-29 03:35:30 PST
Comment on attachment 77577 [details] Patch (part 4) Clearing flags on attachment: 77577 Committed r74739: <http://trac.webkit.org/changeset/74739>
WebKit Commit Bot
Comment 20 2010-12-29 03:35:38 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.