Bug 50426 - Need to move all code that applies correction into correction panel callback.
Summary: Need to move all code that applies correction into correction panel callback.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.6
: P2 Normal
Assignee: Jia Pu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2010-12-02 17:02 PST by Jia Pu
Modified: 2010-12-03 12:45 PST (History)
7 users (show)

See Also:


Attachments
Proposed patch (v1) (65.03 KB, patch)
2010-12-02 19:17 PST, Jia Pu
no flags Details | Formatted Diff | Diff
Proposed patch (v2) (65.03 KB, patch)
2010-12-02 19:24 PST, Jia Pu
no flags Details | Formatted Diff | Diff
Proposed patch (v3) (66.50 KB, patch)
2010-12-02 23:33 PST, Jia Pu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jia Pu 2010-12-02 17:02:00 PST
This change is necessary for WebKit to work with next AppKit build. More specifically, this means all calls to applyCorrectionPanelInfo() need to be moved into Editor::handleCorrectionPanelResult().
Comment 1 Jia Pu 2010-12-02 17:07:48 PST
<rdar://problem/8720832>
Comment 2 Jia Pu 2010-12-02 19:17:32 PST
Created attachment 75452 [details]
Proposed patch (v1)
Comment 3 Jia Pu 2010-12-02 19:24:11 PST
Created attachment 75454 [details]
Proposed patch (v2)

Fixed a typo.
Comment 4 Early Warning System Bot 2010-12-02 19:31:46 PST
Attachment 75452 [details] did not build on qt:
Build output: http://queues.webkit.org/results/6818012
Comment 5 WebKit Review Bot 2010-12-02 19:39:58 PST
Attachment 75452 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/6803026
Comment 6 Early Warning System Bot 2010-12-02 19:50:45 PST
Attachment 75454 [details] did not build on qt:
Build output: http://queues.webkit.org/results/6729027
Comment 7 Build Bot 2010-12-02 20:05:50 PST
Attachment 75452 [details] did not build on win:
Build output: http://queues.webkit.org/results/6745017
Comment 8 Build Bot 2010-12-02 20:16:31 PST
Attachment 75454 [details] did not build on win:
Build output: http://queues.webkit.org/results/6814019
Comment 9 WebKit Review Bot 2010-12-02 20:23:35 PST
Attachment 75454 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/6779017
Comment 10 Jia Pu 2010-12-02 23:33:06 PST
Created attachment 75468 [details]
Proposed patch (v3)

Fixed build failures.
Comment 11 Darin Adler 2010-12-03 09:55:47 PST
Comment on attachment 75468 [details]
Proposed patch (v3)

Looks OK.
Comment 12 Jia Pu 2010-12-03 10:02:57 PST
Comment on attachment 75468 [details]
Proposed patch (v3)

Thanks for reviewing, Darin. Could you cq+ it?
Comment 13 WebKit Commit Bot 2010-12-03 12:45:52 PST
Comment on attachment 75468 [details]
Proposed patch (v3)

Clearing flags on attachment: 75468

Committed r73287: <http://trac.webkit.org/changeset/73287>
Comment 14 WebKit Commit Bot 2010-12-03 12:45:58 PST
All reviewed patches have been landed.  Closing bug.