Bug 50425 – Add the ability to run script on 'new' and 'paint' in the test plugin

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Simon Fraser (smfr)]

We need to emulate plugins doing bad things from 'new' and painting.

[Simon Fraser (smfr)]

Created attachment 75439 [details]
Patch

[WebKit Review Bot]

Attachment 75439 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plugins/testplugin-onnew-onpaint-expected.txt', u'LayoutTests/plugins/testplugin-onnew-onpaint.html', u'WebKitTools/ChangeLog', u'WebKitTools/DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp', u'WebKitTools/DumpRenderTree/TestNetscapePlugIn/PluginObject.h', u'WebKitTools/DumpRenderTree/TestNetscapePlugIn/main.cpp']" exit_code: 1
WebKitTools/DumpRenderTree/TestNetscapePlugIn/main.cpp:205:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebKitTools/DumpRenderTree/TestNetscapePlugIn/main.cpp:207:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 2 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Simon Fraser (smfr)]

http://trac.webkit.org/changeset/73226

[WebKit Review Bot]

http://trac.webkit.org/changeset/73226 might have broken Qt Linux Release
The following tests are not passing:
plugins/testplugin-onnew-onpaint.html

[Yuta Kitamura]

On Chromium Linux, there are a lot of plugin test failures which seemed to come from this patch. These tests produce new console messages such as:

>CONSOLE MESSAGE: line 122: PLUGIN: getFocusEvent
>CONSOLE MESSAGE: line 122: PLUGIN: loseFocusEvent

or

>CONSOLE MESSAGE: line 0: PLUGIN: updateEvt

I guess the following hunk caused the regression. Why did you drop these two lines?

@@ -620,8 +657,6 @@ static int16_t handleEventX11(NPP instance, PluginObject* obj, XEvent* event)
 int16_t NPP_HandleEvent(NPP instance, void *event)
 {
     PluginObject* obj = static_cast<PluginObject*>(instance->pdata);
-    if (!obj->eventLogging)
-        return 0;
 
 #ifdef XP_MACOSX
 #ifndef NP_NO_CARBON

[Simon Fraser (smfr)]

I'm going to make this a mac-only test. Please stand by.

[Simon Fraser (smfr)]

(In reply to comment #5)
> I guess the following hunk caused the regression. Why did you drop these two lines?

Because the onPaintEvent trigger needs to be called when handing the drawRect event. I guess I need to fix the other ports.

[Simon Fraser (smfr)]

http://trac.webkit.org/changeset/73235
http://trac.webkit.org/changeset/73236

[Yuta Kitamura]

(In reply to comment #8)
> http://trac.webkit.org/changeset/73235
> http://trac.webkit.org/changeset/73236

It seems Chromium Linux is fixed. Thanks!