make webkit-patch command work when the git branch is not synced to the remote svn branch
Created attachment 75436 [details] Patch
Comment on attachment 75436 [details] Patch Looks plausible to me, but we might want a git ninja's opinion.
Comment on attachment 75436 [details] Patch I don't really understand, but I believe you.
Would be nice to hear from a git ninja, but I'm not sure they'll understand what this change does any better than I do. Do we need to test the case where the commit would fail due to lack of update? Or is that orthogonal to this change?
(In reply to comment #4) > Would be nice to hear from a git ninja, but I'm not sure they'll understand what this change does any better than I do. > > Do we need to test the case where the commit would fail due to lack of update? Or is that orthogonal to this change? That's what the three modified tests are. They used to verify that we'd throw a ScriptError in those cases. Now they verify we committed the right files and not other files. Good test coverage ftw!
Oh, I misread that...actually, you're right, we don't test the case where the commit would fail (e.g. because of a conflict). I'll add that test and commit.
Committed r73384: <http://trac.webkit.org/changeset/73384>