Bug 50421 - Rebaseline server: move existing baselines
Summary: Rebaseline server: move existing baselines
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Mihai Parparita
URL:
Keywords:
Depends on:
Blocks: 47761
  Show dependency treegraph
 
Reported: 2010-12-02 16:44 PST by Mihai Parparita
Modified: 2010-12-03 10:35 PST (History)
1 user (show)

See Also:


Attachments
Patch (10.01 KB, patch)
2010-12-02 16:48 PST, Mihai Parparita
no flags Details | Formatted Diff | Diff
Patch (10.71 KB, patch)
2010-12-03 10:14 PST, Mihai Parparita
tony: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mihai Parparita 2010-12-02 16:44:39 PST
Rebaseline server: move existing baselines
Comment 1 Mihai Parparita 2010-12-02 16:48:28 PST
Created attachment 75431 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-12-02 17:28:33 PST
Comment on attachment 75431 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=75431&action=review

> WebKitTools/Scripts/webkitpy/tool/commands/rebaselineserver.py:281
> +        # Do the actual move.
> +        if extensions_to_move:
> +            extensions_to_move = list(extensions_to_move)

Seems like helper functions could make this clearer. :)
Comment 3 Tony Chang 2010-12-03 09:59:22 PST
Comment on attachment 75431 [details]
Patch

based on eseidel's feedback
Comment 4 Mihai Parparita 2010-12-03 10:14:38 PST
Created attachment 75506 [details]
Patch

Made moving of baselines be in _move_test_baselines
Comment 5 Mihai Parparita 2010-12-03 10:35:49 PST
Committed r73274: <http://trac.webkit.org/changeset/73274>