Bug 50395 - [EFL] Fails to build with non-system cairo
Summary: [EFL] Fails to build with non-system cairo
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-02 09:30 PST by Gustavo Noronha (kov)
Modified: 2010-12-02 23:06 PST (History)
2 users (show)

See Also:

Attachments
proposed fix (1.27 KB, patch)
2010-12-02 09:34 PST, Gustavo Noronha (kov) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gustavo Noronha (kov) 2010-12-02 09:30:45 PST 
While trying to build WebKitEFL with a custom-built cairo, I noticed it was not working. The problem seems to be that FindCairo declares a PATH_SUFFIX, which is added to the end of each PATH given, which causes it to look for ${include_directory_provided_by_pkgconfig}/cairo/cairo.h - which translates to ${prefix}/include/cairo/cairo/cairo.h. I'm attaching a patch that fixes it.
Comment 1 Gustavo Noronha (kov) 2010-12-02 09:34:14 PST 
Created attachment 75388 [details]
proposed fix
Comment 2 Leandro Pereira 2010-12-02 09:37:04 PST 
Looks good to me.
Comment 3 Eric Seidel (no email) 2010-12-02 17:31:10 PST 
Comment on attachment 75388 [details]
proposed fix

OK.  I'm certainly no expert here, but I believe you.
Comment 4 WebKit Commit Bot 2010-12-02 23:06:05 PST 
Comment on attachment 75388 [details]
proposed fix

Clearing flags on attachment: 75388

Committed r73242: <http://trac.webkit.org/changeset/73242>
Comment 5 WebKit Commit Bot 2010-12-02 23:06:10 PST 
All reviewed patches have been landed.  Closing bug.