Bug 50378 – Enable DEP at runtime to allow for compatibility with older versions of ATL

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Steve Falkenburg]

Enable DEP at runtime to allow for compatibility with older versions of ATL

[Steve Falkenburg]

Created attachment 75359 [details]
Patch

[Adam Roben (:aroben)]

Comment on attachment 75359 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=75359&action=review

> WebKit2/WebProcess/win/WebProcessMainWin.cpp:45
> +    const DWORD disableATLThunkEmulation = 0x00000002;

Maybe we don't need to declare this, since we don't use it?

> WebKit2/WebProcess/win/WebProcessMainWin.cpp:47
> +    HMODULE hMod = GetModuleHandleW(L"Kernel32.dll");

Please add a :: here.

> WebKit2/WebProcess/win/WebProcessMainWin.cpp:53
> +    PSETDEP procSet = reinterpret_cast<PSETDEP>(GetProcAddress(hMod, "SetProcessDEPPolicy"));

And here.

> WebKit2/WebProcess/win/WebProcessMainWin.cpp:83
> +    enableDataExecutionPrevention();

Seems like this should go in WebKitMain instead. We already have similar code there.

[Adam Roben (:aroben)]

Comment on attachment 75359 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=75359&action=review

>> WebKit2/WebProcess/win/WebProcessMainWin.cpp:83
>> +    enableDataExecutionPrevention();
> 
> Seems like this should go in WebKitMain instead. We already have similar code there.

By putting it in WebKitMain it will get used by the plugin process, too (once we have one).

[Steve Falkenburg]

Committed r73138: <http://trac.webkit.org/changeset/73138>