Bug 50371 – Implement focus ring support for image maps

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Daniel Bates]

We should add support for drawing a focus ring for image maps (i.e. implement GraphicsContext::drawFocusRing(const Path& path, ...)).

[Daniel Bates]

Created attachment 75352 [details]
[Patch] Part 1 of 2 (GraphicsContext::drawFocusRing(const Path& path, ...))

Part 1 of 2

I thought to break this patch up into two parts so as to make it easier to look over the changes. The first part implements GraphicsContext::drawFocusRing(const Path& path, ...) and the second part includes layout tests.

I was unclear how to draw paths that describe a rectangular focus ring (e.g. <area shape="rect" ...>) with rounded corners using the Cairo/GTK API. Further investigation is needed. If anyone can save me some time with some insight/suggestions, I would appreciate it.

[Daniel Bates]

Created attachment 75353 [details]
[Patch] Part 2 of 2 (Layout tests and updated results)

Part 2 of 2.

Added tests fast/images/imagemap-circle-focus-ring.html and fast/images/imagemap-polygon-focus-ring.html.

Generated render-tree dumps/pixel-test results for fast/images/imagemap-focus-ring.html, fast/images/imagemap-focus-ring-outline-color.html, fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map.html, and fast/images/imagemap-focus-ring-zoom.html.

[Daniel Bates]

Created attachment 75637 [details]
[Patch] Part 1 of 2 (GraphicsContext::drawFocusRing(const Path& path, ...))

Rebased patch for part 1 since it became stale.

[Martin Robinson]

Comment on attachment 75637 [details]
[Patch] Part 1 of 2 (GraphicsContext::drawFocusRing(const Path& path, ...))

Thank you!

[WebKit Review Bot]

Attachment 75637 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/6788077

[Daniel Bates]

Committed r73490: <http://trac.webkit.org/changeset/73490>