Bug 50371 - Implement focus ring support for image maps
Summary: Implement focus ring support for image maps
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, PlatformOnly
Depends on:
Blocks:
 
Reported: 2010-12-01 21:59 PST by Daniel Bates
Modified: 2010-12-07 20:50 PST (History)
6 users (show)

See Also:


Attachments
[Patch] Part 1 of 2 (GraphicsContext::drawFocusRing(const Path& path, ...)) (4.27 KB, patch)
2010-12-01 22:15 PST, Daniel Bates
no flags Details | Formatted Diff | Diff
[Patch] Part 2 of 2 (Layout tests and updated results) (235.64 KB, patch)
2010-12-01 22:18 PST, Daniel Bates
mrobinson: review+
Details | Formatted Diff | Diff
[Patch] Part 1 of 2 (GraphicsContext::drawFocusRing(const Path& path, ...)) (4.29 KB, patch)
2010-12-05 12:13 PST, Daniel Bates
mrobinson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2010-12-01 21:59:58 PST
We should add support for drawing a focus ring for image maps (i.e. implement GraphicsContext::drawFocusRing(const Path& path, ...)).
Comment 1 Daniel Bates 2010-12-01 22:15:21 PST
Created attachment 75352 [details]
[Patch] Part 1 of 2 (GraphicsContext::drawFocusRing(const Path& path, ...))

Part 1 of 2

I thought to break this patch up into two parts so as to make it easier to look over the changes. The first part implements GraphicsContext::drawFocusRing(const Path& path, ...) and the second part includes layout tests.

I was unclear how to draw paths that describe a rectangular focus ring (e.g. <area shape="rect" ...>) with rounded corners using the Cairo/GTK API. Further investigation is needed. If anyone can save me some time with some insight/suggestions, I would appreciate it.
Comment 2 Daniel Bates 2010-12-01 22:18:58 PST
Created attachment 75353 [details]
[Patch] Part 2 of 2 (Layout tests and updated results)

Part 2 of 2.

Added tests fast/images/imagemap-circle-focus-ring.html and fast/images/imagemap-polygon-focus-ring.html.

Generated render-tree dumps/pixel-test results for fast/images/imagemap-focus-ring.html, fast/images/imagemap-focus-ring-outline-color.html, fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map.html, and fast/images/imagemap-focus-ring-zoom.html.
Comment 3 Daniel Bates 2010-12-05 12:13:31 PST
Created attachment 75637 [details]
[Patch] Part 1 of 2 (GraphicsContext::drawFocusRing(const Path& path, ...))

Rebased patch for part 1 since it became stale.
Comment 4 Martin Robinson 2010-12-07 01:24:56 PST
Comment on attachment 75637 [details]
[Patch] Part 1 of 2 (GraphicsContext::drawFocusRing(const Path& path, ...))

Thank you!
Comment 5 WebKit Review Bot 2010-12-07 20:27:08 PST
Attachment 75637 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/6788077
Comment 6 Daniel Bates 2010-12-07 20:50:18 PST
Committed r73490: <http://trac.webkit.org/changeset/73490>