Currently TestTypeBase.compare_output() method takes a filename as one of parameters.
It would be better to takes a TestInput object as a parameter instead of a filename.
We'll need information which a TestInput object holds to support reftests.
Created attachment 75339 [details]
Comment on attachment 75339 [details]
Your ChangeLog shoudl say "why" and doesn't. Please update before landing.
Committed r73228: <http://trac.webkit.org/changeset/73228>
Eric, thank you for the review.
I merged this patch with ToT and updated ChangeLog and submitted it.
It seemed that r73211 broke Chromium's "Webkit Win (dbg)(2)" bot. Unfortunately, there is some conflict with this change, so I needed to roll out this patch.
Feel free to re-land this patch after r73211 is rolled out. Thank you for your understandings.
Sounds like this needs to be landed again?
Attachment 75339 [details] was posted by a committer and has review+, assigning to Hayato Ito for commit.
This patch became obsolete. I marked it as 'WONTFIX'.