Bug 50340 - build-webkit --chromium always updates DEPS and re-generates project files
Summary: build-webkit --chromium always updates DEPS and re-generates project files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Mihai Parparita
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-01 11:38 PST by Mihai Parparita
Modified: 2010-12-01 16:58 PST (History)
5 users (show)

See Also:

Attachments
Patch (2.45 KB, patch)
2010-12-01 11:47 PST, Mihai Parparita 		no flags Details | Formatted Diff | Diff
Patch (3.17 KB, patch)
2010-12-01 14:11 PST, Mihai Parparita 		abarth: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mihai Parparita 2010-12-01 11:38:15 PST 
build-webkit --chromium always updates DEPS and re-generates project files
Comment 1 Mihai Parparita 2010-12-01 11:47:12 PST 
Created attachment 75298 [details]
Patch
Comment 2 Tony Chang 2010-12-01 11:53:00 PST 
Comment on attachment 75298 [details]
Patch

Yay!
Comment 3 Mihai Parparita 2010-12-01 11:54:44 PST 
I'll give Adam and Eric a chance to say no :)
Comment 4 Eric Seidel (no email) 2010-12-01 12:36:43 PST 
I support this idea. :)
Comment 5 Adam Barth 2010-12-01 12:46:17 PST 
Comment on attachment 75298 [details]
Patch

This will break the Chromium EWS bot when folks modify GYP or DEPs files in their patch.  Can you change the build command used by the bot to pass this new flag?
Comment 6 Mihai Parparita 2010-12-01 14:11:10 PST 
Created attachment 75322 [details]
Patch
Comment 7 Adam Barth 2010-12-01 15:38:34 PST 
Comment on attachment 75322 [details]
Patch

Thanks!

I'm surprised that doesn't break any webkitpy unit tests.
Comment 8 Mihai Parparita 2010-12-01 15:47:18 PST 
(In reply to comment #7)
> I'm surprised that doesn't break any webkitpy unit tests.

Ah, good point. WebKitPortTest.test_chromium_port did need to be updated. Will fix and land.
Comment 9 Mihai Parparita 2010-12-01 16:04:16 PST 
Committed r73082: <http://trac.webkit.org/changeset/73082>
Comment 10 WebKit Review Bot 2010-12-01 16:49:03 PST 
http://trac.webkit.org/changeset/73082 might have broken SnowLeopard Intel Release (Tests)
Comment 11 Mihai Parparita 2010-12-01 16:58:03 PST 
(In reply to comment #10)
> http://trac.webkit.org/changeset/73082 might have broken SnowLeopard Intel Release (Tests)

fast/profiler/throw-exception-from-eval.html has diffs in the stack trace that's output, I don't see how this could cause that.