Bug 50335 - Missing DOM property for incremental input attribute
Summary: Missing DOM property for incremental input attribute
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Minor
Assignee: Erik Arvidsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-01 10:40 PST by Erik Arvidsson
Modified: 2010-12-02 11:22 PST (History)
3 users (show)

See Also:


Attachments
Patch (6.54 KB, patch)
2010-12-01 16:27 PST, Erik Arvidsson
no flags Details | Formatted Diff | Diff
Patch (4.16 KB, patch)
2010-12-01 16:58 PST, Erik Arvidsson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Erik Arvidsson 2010-12-01 10:40:07 PST
There should be a DOM property that maps to the incremental input attribute.
Comment 1 Erik Arvidsson 2010-12-01 16:27:17 PST
Created attachment 75332 [details]
Patch
Comment 2 Darin Adler 2010-12-01 16:30:28 PST
Comment on attachment 75332 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=75332&action=review

review- because I would prefer that we not add unused functions to the class. Now that we have Reflect, we don’t need to write C++ getters and setters for most attributes, although there are exceptions.

> WebCore/html/HTMLInputElement.cpp:1586
> +bool HTMLInputElement::incremental() const
> +{
> +    return fastHasAttribute(incrementalAttr);
> +}
> +
> +void HTMLInputElement::setIncremental(bool incremental)
> +{
> +    setBooleanAttribute(incrementalAttr, incremental);
> +}

These are not needed. No reason to add these.

> WebCore/html/HTMLInputElement.h:198
> +    bool incremental() const;
> +    void setIncremental(bool);

These are not needed. No reason to add these.

> WebCore/html/HTMLInputElement.idl:73
> +        attribute [Reflect] boolean incremental;

This is enough to fix the bug.
Comment 3 Erik Arvidsson 2010-12-01 16:58:32 PST
Created attachment 75335 [details]
Patch
Comment 4 WebKit Commit Bot 2010-12-02 11:22:08 PST
Comment on attachment 75335 [details]
Patch

Clearing flags on attachment: 75335

Committed r73168: <http://trac.webkit.org/changeset/73168>
Comment 5 WebKit Commit Bot 2010-12-02 11:22:14 PST
All reviewed patches have been landed.  Closing bug.