Bug 50304 - Web Inspector: do not make helpScreen.css lazily loaded.
Summary: Web Inspector: do not make helpScreen.css lazily loaded.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-30 17:50 PST by Pavel Feldman
Modified: 2010-12-01 07:54 PST (History)
10 users (show)

See Also:

Attachments
[PATCH] Proposed change (2.57 KB, patch)
2010-11-30 17:52 PST, Pavel Feldman 		yurys: review+
yurys: commit-queue+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2010-11-30 17:50:20 PST 
Otherwise it blinks. Patch to follow.

helpScreen.css is only 150 lines, with primitive selectors only.
Comment 1 Pavel Feldman 2010-11-30 17:52:50 PST 
Created attachment 75238 [details]
[PATCH] Proposed change
Comment 2 Timothy Hatcher 2010-11-30 20:31:08 PST 
You could fix this by listening for the load event on the link element and aiting to show the help element until it is loaded.
Comment 3 Pavel Feldman 2010-12-01 07:54:41 PST 
(In reply to comment #2)
> You could fix this by listening for the load event on the link element and aiting to show the help element until it is loaded.

I am thinking of iframe-ifying parts of the inspector (i.e. hosting TextViewer in iframe as originally was with SourceFrame, hosting network log in iframe, maybe help screen). The rationale is that number of the css rules multiplied by the size of the dom makes us render slowly. Localized doms with localized styles will be a better fit... 

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/HelpScreen.js
	M	WebCore/inspector/front-end/inspector.html
Committed r73021