Bug 50302 - Text search should treat all matches as word-start matches when the target begins with a separator character
Summary: Text search should treat all matches as word-start matches when the target be...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: mitz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-30 17:27 PST by mitz
Modified: 2010-11-30 18:31 PST (History)
3 users (show)

See Also:

Attachments
Patch (11.99 KB, patch)
2010-11-30 17:31 PST, mitz 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2010-11-30 17:27:46 PST 
Text search should treat all matches as word-start matches when the target begins with a separator character
Comment 1 mitz 2010-11-30 17:31:33 PST 
Created attachment 75237 [details]
Patch
Comment 2 Darin Adler 2010-11-30 17:34:40 PST 
Comment on attachment 75237 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=75237&action=review

> WebCore/editing/TextIterator.cpp:1897
> +    if (m_options & AtWordStarts && targetLength) {
> +        UChar32 targetFirstCharacter;
> +        U16_GET(m_target.characters(), 0, 0, m_target.length(), targetFirstCharacter);

You probably need parentheses to avoid annoying newest gcc.

Why not use targetLength here instead of m_target.length()?

> WebCore/editing/TextIterator.cpp:1898
> +        // Characters in the separator category are never really occur at the beginning of a word,

"are never really occur" is wrong -- I suggest removing a word
Comment 3 mitz 2010-11-30 17:50:19 PST 
Fixed in <http://trac.webkit.org/projects/webkit/changeset/72989>.
Comment 4 WebKit Review Bot 2010-11-30 18:31:50 PST 
http://trac.webkit.org/changeset/72989 might have broken Qt Linux ARMv7 Release