RESOLVED FIXED 50302
Text search should treat all matches as word-start matches when the target begins with a separator character 
https://bugs.webkit.org/show_bug.cgi?id=50302
Summary Text search should treat all matches as word-start matches when the target be...
mitz
Reported 2010-11-30 17:27:46 PST
Text search should treat all matches as word-start matches when the target begins with a separator character
Attachments
Patch (11.99 KB, patch)
2010-11-30 17:31 PST, mitz 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2010-11-30 17:31:33 PST
Created attachment 75237 [details] Patch
Darin Adler
Comment 2 2010-11-30 17:34:40 PST
Comment on attachment 75237 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=75237&action=review > WebCore/editing/TextIterator.cpp:1897 > + if (m_options & AtWordStarts && targetLength) { > + UChar32 targetFirstCharacter; > + U16_GET(m_target.characters(), 0, 0, m_target.length(), targetFirstCharacter); You probably need parentheses to avoid annoying newest gcc. Why not use targetLength here instead of m_target.length()? > WebCore/editing/TextIterator.cpp:1898 > + // Characters in the separator category are never really occur at the beginning of a word, "are never really occur" is wrong -- I suggest removing a word
mitz
Comment 3 2010-11-30 17:50:19 PST
Fixed in <http://trac.webkit.org/projects/webkit/changeset/72989>.
WebKit Review Bot
Comment 4 2010-11-30 18:31:50 PST
http://trac.webkit.org/changeset/72989 might have broken Qt Linux ARMv7 Release
Note You need to log in before you can comment on or make changes to this bug.