Bug 50294 – [OpenVG] Remove "current path" of GraphicsContext

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Patrick R. Gansterer]

see patch

[Patrick R. Gansterer]

Created attachment 75226 [details]
Patch

[Jakob Petsovits]

Comment on attachment 75226 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=75226&action=review

Big fan of the patch overall! Just two minor nitpicks from my side (I'm not a reviewer though).

> WebCore/platform/graphics/openvg/PainterOpenVG.cpp:733
> +    path.platformPath()->makeCompatibleContextCurrent();

This is not necessary. We want the surface current that's being drawn on, and need to expect the path to be compatible to that surface, otherwise we won't get anything drawn anyways.

> WebCore/platform/graphics/openvg/PainterOpenVG.h:139
> +} // namespace WebCore

On his initial review, Niko advised me against these labels, indicating that it's probably "better" WebKit coding style. I'd say leave it like that, because there's no good reason to change and it doesn't thematically belong in this commit.

[Patrick R. Gansterer]

Created attachment 75261 [details]
Patch

[Patrick R. Gansterer]

Comment on attachment 75261 [details]
Patch

patch won't apply, I'll commit it manually

[Patrick R. Gansterer]

Comment on attachment 75261 [details]
Patch

Clearing flags on attachment: 75261

Manually committed r73184: <http://trac.webkit.org/changeset/73184>

[Patrick R. Gansterer]

All reviewed patches have been landed.  Closing bug.