Bug 50285 – [chromium] histograms api updated in WebKitClient and added to ChromiumBridge

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Vincent Scheib]

[chromium] histograms api updated in WebKitClient and added to ChromiumBridge

[Vincent Scheib]

Created attachment 75225 [details]
Patch

[Darin Fisher (:fishd, Google)]

Comment on attachment 75225 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=75225&action=review

> WebCore/platform/chromium/ChromiumBridge.h:242
> +        static void histogramCustomCounts(const char* name, int sample, int min, int max, int bucketCount);

Why the "custom" modifier?  Why not just call this histogramCounts?

[Vincent Scheib]

Comment on attachment 75225 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=75225&action=review

>> WebCore/platform/chromium/ChromiumBridge.h:242
>> +        static void histogramCustomCounts(const char* name, int sample, int min, int max, int bucketCount);
> 
> Why the "custom" modifier?  Why not just call this histogramCounts?

This mimics the low level api name used in Chromium HISTOGRAM_CUSTOM_COUNTS, the name HISTOGRAM_COUNTS is used with only two parameters (name, sample).

[Darin Fisher (:fishd, Google)]

Comment on attachment 75225 [details]
Patch

Ah, R=me

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 75225 [details]:

http/tests/misc/copy-resolves-urls.html

Please file bugs against the tests.  These tests were authored by [e-mail].  The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 75225 [details]
Patch

Clearing flags on attachment: 75225

Committed r73137: <http://trac.webkit.org/changeset/73137>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.