Bug 50273 - update-webkit should call git fetch before git svn rebase
Summary: update-webkit should call git fetch before git svn rebase
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-30 14:11 PST by Eric Seidel (no email)
Modified: 2010-11-30 14:51 PST (History)
2 users (show)

See Also:


Attachments
Patch (2.05 KB, patch)
2010-11-30 14:18 PST, Eric Seidel (no email)
tony: review+
tony: commit-queue+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-11-30 14:11:25 PST
update-webkit should call git fetch before git svn rebase
Comment 1 Eric Seidel (no email) 2010-11-30 14:18:58 PST
Created attachment 75202 [details]
Patch
Comment 2 Tony Chang 2010-11-30 14:23:55 PST
Comment on attachment 75202 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=75202&action=review

> WebKitTools/ChangeLog:12
> +        This change should have no affect on people using the "old" git setup

Heh, I think I've been using this setup for over a year.
Comment 3 Eric Seidel (no email) 2010-11-30 14:26:46 PST
Sigh.  I fixed Mihai's spelling mistake and made one of my own.  I should have used "effect".
Comment 4 Tony Chang 2010-11-30 14:31:26 PST
Comment on attachment 75202 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=75202&action=review

> WebKitTools/Scripts/update-webkit:130
> +    # to preform the rebase much much faster.

Ojan says this should be "perform".
Comment 5 Eric Seidel (no email) 2010-11-30 14:51:00 PST
Committed r72966: <http://trac.webkit.org/changeset/72966>