RESOLVED DUPLICATE of bug 50244 Bug 50271
[V8] Code generation script misplaces headers 
https://bugs.webkit.org/show_bug.cgi?id=50271
Summary [V8] Code generation script misplaces headers
Russell Brenner
Reported 2010-11-30 13:37:44 PST
While merging webkit r72274 onto android, compilation errors were found in the output of CodeGeneratorV8.pm associated with these native types: SVGListPropertyTearOff, SVGStaticListPropertyTearOff, and SVGTransformListPropertyTearOff. The problem is resolved by moving associated header files from $implIncludes to $headerIncludes (patch to follow shortly).
Attachments
proposed patch (1.80 KB, patch)
2010-11-30 13:47 PST, Russell Brenner 		no flags
DetailsFormatted DiffDiff
proposed patch (1.89 KB, patch)
2010-12-01 09:55 PST, Russell Brenner 		no flags
DetailsFormatted DiffDiff
Patch (1.63 KB, patch)
2010-12-01 13:40 PST, Steve Block 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Russell Brenner
Comment 1 2010-11-30 13:47:17 PST
Created attachment 75198 [details] proposed patch
Steve Block
Comment 2 2010-12-01 09:31:52 PST
Comment on attachment 75198 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=75198&action=review Set cq? if you'd like the reviewer to land the patch via the commit queue once it's r+'ed. > WebCore/ChangeLog:5 > + [V8] Code generation script misplaces headers Use spaces, not tabs. > WebCore/ChangeLog:13 > + All WebCore ChangeLog entries need a line saying which (new) tests they're covered by, or why no tests are required. Here 'Build fix only, no new tests' is OK.
Russell Brenner
Comment 3 2010-12-01 09:55:21 PST
Created attachment 75281 [details] proposed patch Replaced tabs with spaces and added line for "no new tests" in ChangeLog.
Steve Block
Comment 4 2010-12-01 10:16:51 PST
Comment on attachment 75281 [details] proposed patch LGTM, but there's no point me setting cq+ because it looks like you need to rebase (the try-bots failed to apply the patch).
Russell Brenner
Comment 5 2010-12-01 13:14:16 PST
*** This bug has been marked as a duplicate of bug 50244 ***
David Levin
Comment 6 2010-12-01 13:30:39 PST
Comment on attachment 75281 [details] proposed patch Cleared flags on obsolete patch.
Steve Block
Comment 7 2010-12-01 13:40:19 PST
Created attachment 75318 [details] Patch
Steve Block
Comment 8 2010-12-01 13:58:46 PST
Comment on attachment 75318 [details] Patch No longer required
Note You need to log in before you can comment on or make changes to this bug.