Bug 50269 - [Qt] GraphicsContext::strokeRect() taints the context's lineWidth
Summary: [Qt] GraphicsContext::strokeRect() taints the context's lineWidth
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords: HTML5, Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2010-11-30 13:35 PST by Andreas Kling
Modified: 2010-12-02 05:51 PST (History)
2 users (show)

See Also:


Attachments
Proposed patch (5.49 KB, patch)
2010-11-30 13:40 PST, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2010-11-30 13:35:41 PST
GraphicsContext::strokeRect() currently calls setStrokeThickness() without restoring the original value after stroking.
This is exposed to the web via a WebKit-specific strokeRect() overload in the Canvas API.
Comment 1 Andreas Kling 2010-11-30 13:40:43 PST
Created attachment 75194 [details]
Proposed patch
Comment 2 WebKit Commit Bot 2010-12-02 04:35:25 PST
The commit-queue encountered the following flaky tests while processing attachment 75194 [details]:

fast/preloader/script.html
fast/loader/recursive-before-unload-crash.html

Please file bugs against the tests.  These tests were authored by abarth@webkit.org, beidson@apple.com, and eric@webkit.org.  The commit-queue is continuing to process your patch.
Comment 3 WebKit Commit Bot 2010-12-02 05:08:16 PST
The commit-queue encountered the following flaky tests while processing attachment 75194 [details]:

fast/images/load-img-with-empty-src.html
fast/preloader/script.html

Please file bugs against the tests.  These tests were authored by abarth@webkit.org and mitz@webkit.org.  The commit-queue is continuing to process your patch.
Comment 4 WebKit Commit Bot 2010-12-02 05:21:34 PST
The commit-queue encountered the following flaky tests while processing attachment 75194 [details]:

compositing/reflections/nested-reflection-animated.html
animations/play-state-suspend.html

Please file bugs against the tests.  These tests were authored by cmarrin@apple.com and simon.fraser@apple.com.  The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2010-12-02 05:22:21 PST
The commit-queue encountered the following flaky tests while processing attachment 75194 [details]:

http/tests/misc/script-async.html
java/lc3/JSObject/ToObject-001.html

Please file bugs against the tests.  These tests were authored by ap@webkit.org and tonyg@chromium.org.  The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2010-12-02 05:39:37 PST
Comment on attachment 75194 [details]
Proposed patch

Clearing flags on attachment: 75194

Committed r73125: <http://trac.webkit.org/changeset/73125>
Comment 7 WebKit Commit Bot 2010-12-02 05:39:43 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 WebKit Commit Bot 2010-12-02 05:51:20 PST
The commit-queue encountered the following flaky tests while processing attachment 75194 [details]:

fast/loader/recursive-before-unload-crash.html
fast/preloader/script.html

Please file bugs against the tests.  These tests were authored by abarth@webkit.org, beidson@apple.com, and eric@webkit.org.  The commit-queue is continuing to process your patch.