Bug 50257 - [Qt] [WK2] Build system improvements for non-Unix targets
Summary: [Qt] [WK2] Build system improvements for non-Unix targets
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Minor
Assignee: Siddharth Mathur
URL:
Keywords: Qt
Depends on:
Blocks: 50251
  Show dependency treegraph
 
Reported: 2010-11-30 11:51 PST by Siddharth Mathur
Modified: 2010-12-03 15:35 PST (History)
2 users (show)

See Also:


Attachments
Fix directory seperators for Windows as host (2.51 KB, patch)
2010-11-30 15:36 PST, Siddharth Mathur
no flags Details | Formatted Diff | Diff
Updated patch for Windows build host and ARMCC flag (4.54 KB, patch)
2010-11-30 17:14 PST, Siddharth Mathur
laszlo.gombos: review-
Details | Formatted Diff | Diff
updated patch with only changes requested by Laszlo (2.54 KB, patch)
2010-12-03 11:41 PST, Siddharth Mathur
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Siddharth Mathur 2010-11-30 11:51:48 PST
Fixes to .pro/.pri files for non-Linux based Qt platforms.
Comment 1 Siddharth Mathur 2010-11-30 15:36:05 PST
Created attachment 75218 [details]
Fix directory seperators for Windows as host
Comment 2 Siddharth Mathur 2010-11-30 17:14:51 PST
Created attachment 75236 [details]
Updated patch for Windows build host and ARMCC flag
Comment 3 Laszlo Gombos 2010-12-01 05:59:45 PST
Comment on attachment 75236 [details]
Updated patch for Windows build host and ARMCC flag

This patch does not seems to apply cleanly to the trunk, r- for that.

Also, have you successfully used --preinclude in any environment ? If not than this code is speculative and I think we should not land it until we used it successfully. 

Perhaps you can resolve the conflict with the trunk and resubmit the patch without the "--preinclude" changes.
Comment 4 Siddharth Mathur 2010-12-03 11:41:10 PST
Created attachment 75519 [details]
updated patch with only changes requested by Laszlo
Comment 5 Laszlo Gombos 2010-12-03 13:03:12 PST
Comment on attachment 75519 [details]
updated patch with only changes requested by Laszlo

looks great, thanks. r+.
Comment 6 WebKit Commit Bot 2010-12-03 15:35:15 PST
Comment on attachment 75519 [details]
updated patch with only changes requested by Laszlo

Clearing flags on attachment: 75519

Committed r73313: <http://trac.webkit.org/changeset/73313>
Comment 7 WebKit Commit Bot 2010-12-03 15:35:20 PST
All reviewed patches have been landed.  Closing bug.