Bug 50252 – [GTK] Fix compilation warnings reported by clang

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Alejandro G. Castro]

Running with clang outputs some warnings, there are still other issues that avoid the compilation that we will probably have to fix before in other projects to have the complete support.

[Alejandro G. Castro]

Created attachment 75179 [details]
Proposed patch

[WebKit Review Bot]

Attachment 75179 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'WebCore/ChangeLog', u'WebCore/platform/graphics/Path.h', u'WebCore/platform/network/soup/ResourceHandleSoup.cpp', u'WebKitTools/ChangeLog', u'WebKitTools/GtkLauncher/main.c']" exit_code: 1
WebKitTools/GtkLauncher/main.c:221:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alejandro G. Castro]

(In reply to comment #2)
> Attachment 75179 [details] did not pass style-queue:
> 
> Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'WebCore/ChangeLog', u'WebCore/platform/graphics/Path.h', u'WebCore/platform/network/soup/ResourceHandleSoup.cpp', u'WebKitTools/ChangeLog', u'WebKitTools/GtkLauncher/main.c']" exit_code: 1
> WebKitTools/GtkLauncher/main.c:221:  Extra space before ( in function call  [whitespace/parens] [4]
> Total errors found: 1 in 5 files
> 

False positive, that file has gtk style, not sure if we should change that at some point.

[Xan Lopez]

Comment on attachment 75179 [details]
Proposed patch

Should either make GtkLauncher follow WebKit style or make an exception in the script. My vote goes for the former.

[Alejandro G. Castro]

(In reply to comment #4)
> (From update of attachment 75179 [details])
> Should either make GtkLauncher follow WebKit style or make an exception in the script. My vote goes for the former.

I agree, I'll upload another bug for that.

[Alejandro G. Castro]

landed http://trac.webkit.org/changeset/73344