Bug 50229 - Cleanup SVGPropertyTraits
Summary: Cleanup SVGPropertyTraits
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nikolas Zimmermann
Depends on:
Blocks: 47905
  Show dependency treegraph
Reported: 2010-11-30 05:51 PST by Nikolas Zimmermann
Modified: 2010-12-01 02:04 PST (History)
3 users (show)

See Also:

Patch (22.77 KB, patch)
2010-11-30 05:55 PST, Nikolas Zimmermann
krit: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2010-11-30 05:51:51 PST
SVGPropertyTraits includes several SVG* files, just to declare the template specializations. We can just move the specializations into the SVG* files, and remove all SVG*.h includes from SVGPropertyTraits.h
Comment 1 Nikolas Zimmermann 2010-11-30 05:55:23 PST
Created attachment 75130 [details]
Comment 2 Dirk Schulze 2010-11-30 09:41:14 PST
Comment on attachment 75130 [details]

LGTM. r=me
Comment 3 Nikolas Zimmermann 2010-12-01 00:51:39 PST
Fixed all style issues locally, wondering why the style bot didn't post a link here.
Chromium EWS does nothing unfortunately, so I'm just risking to land...
Comment 4 Dirk Schulze 2010-12-01 00:56:37 PST
Saw the same problem on other patches. Seems to be a bug in the Style-bot.
Comment 5 Nikolas Zimmermann 2010-12-01 01:03:43 PST
Landed in r73011, closing bug when it builds everywhere.
Comment 6 Nikolas Zimmermann 2010-12-01 02:04:36 PST
Builds just fine, closing bug, marking as blocks 47905, what I forgot before.