Bug 50216 - [WINCE] Add WebView
: [WINCE] Add WebView
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: Platform
: 528+ (Nightly build)
: Other Other
: P2 Normal
Assigned To: Patrick R. Gansterer
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-11-30 02:40 PST by Patrick R. Gansterer
Modified: 2010-11-30 08:30 PST (History)
1 user (show)

See Also:


Attachments
Patch (19.49 KB, patch)
2010-11-30 02:48 PST, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2010-11-30 02:40:01 PST
see patch
Comment 1 Patrick R. Gansterer 2010-11-30 02:48:32 PST
Created attachment 75116 [details]
Patch
Comment 2 Adam Roben (:aroben) 2010-11-30 07:14:41 PST
Comment on attachment 75116 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=75116&action=review

You have a bunch of unnecessary parameter names in WebView.h.

I'm not sure why the style bot didn't catch the style issues.

> WebKit/wince/WebView.cpp:245
> +    if (::GetUpdateRect(hWnd, &updateRect, false)) {

Can you use an early return here?

> WebKit/wince/WebView.h:61
> +    WebCore::FrameView *view() const;

Misplaced *.

> WebKit/wince/WebView.h:80
> +    static LRESULT CALLBACK WebViewWndProc(HWND hWnd, UINT message, WPARAM wParam, LPARAM lParam);
> +    LRESULT WndProc(HWND, UINT, WPARAM, LPARAM);

These should start with lowercase letters.
Comment 3 Patrick R. Gansterer 2010-11-30 08:30:15 PST
Comment on attachment 75116 [details]
Patch

Clearing flags on attachment: 75116

Manually committed r72916: <http://trac.webkit.org/changeset/72916>
Comment 4 Patrick R. Gansterer 2010-11-30 08:30:34 PST
All reviewed patches have been landed.  Closing bug.