Bug 50216 - [WINCE] Add WebView
: [WINCE] Add WebView
Status: RESOLVED FIXED
: WebKit
Platform
: 528+ (Nightly build)
: Other Other
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2010-11-30 02:40 PST by
Modified: 2010-11-30 08:30 PST (History)


Attachments
Patch (19.49 KB, patch)
2010-11-30 02:48 PST, Patrick R. Gansterer
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2010-11-30 02:40:01 PST
see patch
------- Comment #1 From 2010-11-30 02:48:32 PST -------
Created an attachment (id=75116) [details]
Patch
------- Comment #2 From 2010-11-30 07:14:41 PST -------
(From update of attachment 75116 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=75116&action=review

You have a bunch of unnecessary parameter names in WebView.h.

I'm not sure why the style bot didn't catch the style issues.

> WebKit/wince/WebView.cpp:245
> +    if (::GetUpdateRect(hWnd, &updateRect, false)) {

Can you use an early return here?

> WebKit/wince/WebView.h:61
> +    WebCore::FrameView *view() const;

Misplaced *.

> WebKit/wince/WebView.h:80
> +    static LRESULT CALLBACK WebViewWndProc(HWND hWnd, UINT message, WPARAM wParam, LPARAM lParam);
> +    LRESULT WndProc(HWND, UINT, WPARAM, LPARAM);

These should start with lowercase letters.
------- Comment #3 From 2010-11-30 08:30:15 PST -------
(From update of attachment 75116 [details])
Clearing flags on attachment: 75116

Manually committed r72916: <http://trac.webkit.org/changeset/72916>
------- Comment #4 From 2010-11-30 08:30:34 PST -------
All reviewed patches have been landed.  Closing bug.