Bug 50213 - All projects on Windows should use cmd files for build events
Summary: All projects on Windows should use cmd files for build events
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Steve Falkenburg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-30 00:25 PST by Steve Falkenburg
Modified: 2010-11-30 09:53 PST (History)
1 user (show)

See Also:

Attachments
Patch (83.42 KB, patch)
2010-11-30 00:34 PST, Steve Falkenburg 		aroben: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Falkenburg 2010-11-30 00:25:46 PST 
All projects on Windows should use cmd files for build events
Comment 1 Steve Falkenburg 2010-11-30 00:34:13 PST 
Created attachment 75112 [details]
Patch
Comment 2 Adam Roben (:aroben) 2010-11-30 09:12:59 PST 
Comment on attachment 75112 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=75112&action=review

Maybe we should move the which.exe/buildfailed stuff into common.vsprops?

> WebKit2/win/WebKitPreBuild.cmd:11
> +cl /analyze /nologo /c "%WEBKITOUTPUTDIR%\tmp.cpp" /Fo"%INTDIR%\tmp.obj" 2>&1 | findstr D9040
> +if ERRORLEVEL 1 (set EnablePREfast="true") else (set EnablePREfast="false")
> +if ERRORLEVEL 1 (set AnalyzeWithLargeStack="/analyze:65536") else (set AnalyzeWithLargeStack="")

Does anyone use PREfast anymore?
Comment 3 Steve Falkenburg 2010-11-30 09:53:59 PST 
Committed r72923: <http://trac.webkit.org/changeset/72923>