Bug 50207 – Rebaseline server: baseline display tweaks

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Mihai Parparita]

Rebaseline server: baseline display tweaks

[Mihai Parparita]

Created attachment 75102 [details]
Patch

[Tony Chang]

Comment on attachment 75102 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=75102&action=review

> WebKitTools/Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:272
> +        for (var extension in baselines[platform]) {
> +            if (!isFirstExtension) {

Should we sort the extensions too?

> WebKitTools/Scripts/webkitpy/tool/commands/rebaselineserver.py:218
> +            if platform not in all_test_baselines:
> +                all_test_baselines[platform] = {}

Nit: You can use the oddly named setdefault here to save a lookup:
  platform_baselines = all_test_baselines.setdefault(platform, {})
  was_used_for_test = ...
  platform_baselines[baseline_extension] = was_used_for_test

[Mihai Parparita]

(In reply to comment #2)
> (From update of attachment 75102 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=75102&action=review
> 
> > WebKitTools/Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:272
> > +        for (var extension in baselines[platform]) {
> > +            if (!isFirstExtension) {
> 
> Should we sort the extensions too?

Done. Added getSortedKeys(obj) to util.js and used it for both platforms and extensions.
 
> > WebKitTools/Scripts/webkitpy/tool/commands/rebaselineserver.py:218
> > +            if platform not in all_test_baselines:
> > +                all_test_baselines[platform] = {}
> 
> Nit: You can use the oddly named setdefault here to save a lookup:
>   platform_baselines = all_test_baselines.setdefault(platform, {})
>   was_used_for_test = ...
>   platform_baselines[baseline_extension] = was_used_for_test

Switched to setdefault.

[Mihai Parparita]

Committed r72939: <http://trac.webkit.org/changeset/72939>