RESOLVED FIXED 50207
Rebaseline server: baseline display tweaks
https://bugs.webkit.org/show_bug.cgi?id=50207
Summary Rebaseline server: baseline display tweaks
Mihai Parparita
Reported 2010-11-29 21:02:28 PST
Rebaseline server: baseline display tweaks
Attachments
Patch (11.69 KB, patch)
2010-11-29 21:04 PST, Mihai Parparita
tony: review+
Mihai Parparita
Comment 1 2010-11-29 21:04:27 PST
Tony Chang
Comment 2 2010-11-30 09:56:09 PST
Comment on attachment 75102 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=75102&action=review > WebKitTools/Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:272 > + for (var extension in baselines[platform]) { > + if (!isFirstExtension) { Should we sort the extensions too? > WebKitTools/Scripts/webkitpy/tool/commands/rebaselineserver.py:218 > + if platform not in all_test_baselines: > + all_test_baselines[platform] = {} Nit: You can use the oddly named setdefault here to save a lookup: platform_baselines = all_test_baselines.setdefault(platform, {}) was_used_for_test = ... platform_baselines[baseline_extension] = was_used_for_test
Mihai Parparita
Comment 3 2010-11-30 11:21:20 PST
(In reply to comment #2) > (From update of attachment 75102 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=75102&action=review > > > WebKitTools/Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:272 > > + for (var extension in baselines[platform]) { > > + if (!isFirstExtension) { > > Should we sort the extensions too? Done. Added getSortedKeys(obj) to util.js and used it for both platforms and extensions. > > WebKitTools/Scripts/webkitpy/tool/commands/rebaselineserver.py:218 > > + if platform not in all_test_baselines: > > + all_test_baselines[platform] = {} > > Nit: You can use the oddly named setdefault here to save a lookup: > platform_baselines = all_test_baselines.setdefault(platform, {}) > was_used_for_test = ... > platform_baselines[baseline_extension] = was_used_for_test Switched to setdefault.
Mihai Parparita
Comment 4 2010-11-30 11:23:49 PST
Note You need to log in before you can comment on or make changes to this bug.