RESOLVED FIXED50197
config.webkit_base_dir returns a path with a trailing slash 
https://bugs.webkit.org/show_bug.cgi?id=50197
Summary config.webkit_base_dir returns a path with a trailing slash
Mihai Parparita
Reported 2010-11-29 18:01:36 PST
config.webkit_base_dir returns a path with a trailing slash
Attachments
Patch (4.37 KB, patch)
2010-11-29 18:03 PST, Mihai Parparita 		tony: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mihai Parparita
Comment 1 2010-11-29 18:03:37 PST
Created attachment 75094 [details] Patch
Dirk Pranke
Comment 2 2010-11-29 18:40:31 PST
Comment on attachment 75094 [details] Patch Ah. Yep, that would do it. LGTM!
Tony Chang
Comment 3 2010-11-30 09:21:26 PST
Comment on attachment 75094 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=75094&action=review > WebKitTools/Scripts/webkitpy/layout_tests/port/config.py:135 > + self._webkit_base_dir = abspath[0:abspath.find('WebKitTools') - 1] Seems like I could construct cases where this would break, but this seems good enough and concise.
Mihai Parparita
Comment 4 2010-11-30 11:26:20 PST
Comment on attachment 75094 [details] Patch Commit queue is pretty backed up, will land this manually.
Mihai Parparita
Comment 5 2010-11-30 11:27:53 PST
Committed r72940: <http://trac.webkit.org/changeset/72940>
Note You need to log in before you can comment on or make changes to this bug.